Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ACIS tables #32

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Sync ACIS tables #32

merged 1 commit into from
Jul 28, 2023

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented Jul 22, 2023

Description

Add the acis_tables directory, which appropriately enough contains the ACIS tables, to ska_sync.

Interface impacts

Adds two new files totaling about 2.5 Mb to the standard Ska data in $SKA/data/acis_tables.

Testing

Unit tests

  • No unit tests

Functional tests

  • @taldcroft installed the new sync config and confirmed that the ACIS tables get synced
  • @jzuhone installed the new sync config and confirmed that the ACIS tables get synced, verified that they can be read in the same way as before

@jzuhone
Copy link
Contributor Author

jzuhone commented Jul 26, 2023

@taldcroft I forgot to tag you here

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzuhone thanks, LGTM. You should just do the testing and we can merge this.

@jzuhone
Copy link
Contributor Author

jzuhone commented Jul 27, 2023

@taldcroft Did you set up the cron job to copy in the ACIS tables to /proj/sot/ska/data/acis_tables?

@taldcroft
Copy link
Member

@jzuhone - yes, there is now a daily job on HEAD (kady) to do this:

rsync -aL /data/acis/sacgs/odb/current* /proj/sot/ska/data/acis_tables/

@jzuhone
Copy link
Contributor Author

jzuhone commented Jul 27, 2023

@taldcroft I was also able to sync the files, and I tested that they could be read correctly.

@taldcroft taldcroft merged commit 3e1046c into sot:master Jul 28, 2023
@javierggt javierggt mentioned this pull request Sep 6, 2023
@javierggt javierggt mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants