Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change acq anomaly notification from aca_alert to aca email #284

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Aug 7, 2023

Description

Change acq anomaly notification from aca_alert to aca email. See Slack "Why is it that we configured the email to slack bridge again?".

Interface impacts

Changes email notifications.

Testing

Not tested. And unit tests not run. The change is good by inspection.

Functional tests

No functional testing.

@taldcroft taldcroft self-requested a review August 7, 2023 13:40
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The description was lacking somewhat and so I brought it up to standards.

@jeanconn
Copy link
Contributor Author

jeanconn commented Aug 7, 2023

Thanks. Honest, I would have updated it a bit before asking for review!

@jeanconn jeanconn merged commit 0636198 into master Aug 7, 2023
@jeanconn jeanconn deleted the change-email branch August 7, 2023 13:45
This was referenced Sep 18, 2023
@javierggt javierggt mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants