Set plot ymin relative to planning not penalty limit #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
changed the title
jeanconn
force-pushed
the
penalty-plot-range
branch
from
a2c3e56
to
78ff636
Compare
jeanconn
commented
Jul 13, 2023
| @@ -520,7 +520,7 @@ def make_check_plots(outdir, states, times, temps, tstart, tstop, char): | |||
| logger.info('Making temperature check plots') | |||
| for fig_id, msid in enumerate(('aca',)): | |||
| temp_ymax = max(char.aca_t_ccd_planning_limit, np.max(temps)) | |||
| temp_ymin = min(char.aca_t_ccd_penalty_limit, np.min(temps)) | |||
| temp_ymin = min(char.aca_t_ccd_planning_limit - 1, np.min(temps)) | |||
There was a problem hiding this comment.
We could also just auto scale the plot minimum to the data, but I figured there would be no harm in explicitly setting the default min to max range as 1 degree .
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set ACA t_ccd model temperature plot ymin relative to planning not penalty limit. This will be useful if the penalty limit is removed.
Interface impacts
Testing
Unit tests
Functional tests
I set a local version of the ACA thermal model chandra_model to have planning limit -15 and penalty limit 0C and ran on the JUL1723A schedule.
This is the JUL1723A output with the current thermal model limits
As expected, this PR sets the Y minimum to the minimum of the data or the planning limit - 1. I needed to move the planning limit lower to see that the plot change, as most schedules have a data range in which the y min on the plot is driven by the y min of the model data.