Add validator for sun position monitor #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
commented
Jul 31, 2023
| state_name = "sun_pos_mon" | ||
| msids = ["aopssupm"] | ||
| plot_attrs = PlotAttrs(title="Sun position monitor", ylabel="Sun position monitor") | ||
| min_violation_duration = 300 |
There was a problem hiding this comment.
This 300 second value is somewhat empirical from testing. It seems there is variation between the actual eclipse exit (determined by the OBC based on batteries etc) and the predicted which is in commanding. With a 300 second value most of the cases were within the limit.
|
This looks good to me. I note that in review of the report page I see issues with plotting negatives in the Y axis on some of the other plots which I can open as a separate issue. |
|
Thanks. If you are good with this then please approve it. |
|
Still running the unit tests. |
jeanconn
approved these changes
Aug 2, 2023
|
I think this is ready-to-go. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a state validator for the
sun_pos_monstate.It also fixes a bug where telemetry values with a trailing space character (e.g.
"ACT ") do not match the state codes.Interface impacts
Adds a new plot in the state validation page.
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
From within the git repo:
This generated the following output: https://icxc.cfa.harvard.edu/aspect/test_review_outputs/kadi-pr292/