Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stability: add more checks for scale & upgrade #327

Merged
merged 27 commits into from
Mar 22, 2019

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Mar 18, 2019

This PR addresses #309 (comment) .

@zyguan zyguan requested review from weekface and xiaojingchen March 18, 2019 14:58
@zyguan zyguan added the test/stability stability tests label Mar 19, 2019

dumplogs := func() error { return oa.DumpAllLogs(operatorInfo, []*tests.TidbClusterInfo{clusterInfo}) }

// scale out: tidb 2 -> 3, tikv 3 -> 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PD should also be scaled out

perror(oa.CheckTidbClusterStatus(clusterInfo), dumplogs)
perror(oa.CheckScaledCorrectly(clusterInfo, podUIDsBeforeScale), dumplogs)

// scale in: tikv 5 -> 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scale in all the three components

tests/actions.go Outdated
@@ -416,6 +423,63 @@ func (oa *operatorActions) ScaleTidbCluster(info *TidbClusterInfo) error {
return nil
}

func (oa *operatorActions) CheckScaleInSafely(info *TidbClusterInfo) error {
return wait.Poll(5*time.Second, DefaultPollTimeout, func() (done bool, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use DefaultPollInterval

@weekface
Copy link
Contributor

@zyguan Please resolve the conflicts

weekface
weekface previously approved these changes Mar 20, 2019
@zyguan zyguan changed the base branch from stability to master March 22, 2019 02:15
@weekface weekface merged commit f89131a into pingcap:master Mar 22, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test/stability stability tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants