tidb stability test main function #306

shuijing198799 · 2019-03-11T12:45:26Z

commit the main function of TiDB-operator stability test. and create 2 cluster for test.
PTLA @weekface @cwen0 @zyguan @tennix

…ore first

CLAassistant · 2019-03-11T12:45:34Z

All committers have signed the CLA.

zyguan

You'd better use goimports or gofmt to format the code.

zyguan · 2019-03-11T14:00:38Z

tests/actions.go

@@ -43,6 +49,11 @@ func NewOperatorActions(cli versioned.Interface, kubeCli kubernetes.Interface) O
 	}
 }

+const (
+	WAITMINUTE time.Duration = 10
+	WAITSECOND time.Duration = 5


How about

DefaultPollInterval = 10 * time.Second DefaultPollTimeout = 5 * time.Minute

zyguan · 2019-03-11T14:02:07Z

tests/actions.go

+func (oa *operatorActions) CheckAdHocBackup(info *TidbClusterInfo) error {
+	glog.Infof("begin to clean adhoc backup")
+	defer func() {
+		glog.Infof("deploy clean backup end")


clean backup -> check backup

clean is not necessary， for the CleanTidbCluster function will delete all the resources。 but check is necessary for wait the back completed

I mean there is a typo in log message.

zyguan · 2019-03-11T14:08:01Z

tests/actions.go

+	}
+	var buffer bytes.Buffer
+	for k,v := range sets {
+		set := fmt.Sprintf("-l %s=%s",k , v)


let sets = {"foo": "a", "bar": "b"}, you finally get a buffer with "-l foo=a-l bar=b"

there is only one pair in this field , I make some change .thx

zyguan · 2019-03-11T14:12:27Z

tests/actions.go

+	}
+
+	setStr := buffer.String()
+	cmd := fmt.Sprintf("helm update %s /charts/%s/tidb-cluster %s",


zyguan · 2019-03-11T14:14:33Z

tests/actions.go

+		glog.Infof("deploy check scheduler end")
+	}()
+
+	jobName := fmt.Sprintf("%s--scheduled-backup",info.ClusterName)


double dash ?

…oduce by zyguan

weekface · 2019-03-12T03:24:47Z

.gitignore

@@ -7,6 +7,9 @@ images/tidb-operator-e2e/tidb-operator/
 tmp/
 data/
 .idea
+cscope.files


What are these files?

it's ctags generate files only use for me

weekface · 2019-03-12T03:25:54Z

tests/actions.go

@@ -43,6 +49,11 @@ func NewOperatorActions(cli versioned.Interface, kubeCli kubernetes.Interface) O
 	}
 }

+const (
+	DefaultPollTimeout time.Duration = 10 * time.Minute
+	DefaultPollInterval time.Duration = 5 * time.Second


This should be 1 * time.Minute, a longer interval is better.

weekface · 2019-03-12T05:16:48Z

tests/actions.go

+
+	//for the test should add two clusters in a namespace, so we
+	//has to use clustername as an label.
+	sets := map[string]string {


use label.New().Instance().String() instead

weekface · 2019-03-12T05:17:10Z

tests/actions.go

+		}
+	}
+
+	setStr := buffer.String()
 	resources := []string{"cronjobs", "jobs", "pods", "pvc"}


Only need to delete pvc .

weekface · 2019-03-12T05:17:51Z

tests/actions.go

@@ -311,6 +361,22 @@ func (oa *operatorActions) CheckTidbClusterStatus(info *TidbClusterInfo) error {
 	return nil
 }

+func (oa *operatorActions) CreateSecret(info *TidbClusterInfo) error {


Remove this func from this PR. May be another pr.

weekface · 2019-03-12T05:18:08Z

tests/actions.go

@@ -811,3 +868,470 @@ func checkoutTag(tagName string) error {

 	return nil
 }
+
+//scheduler backup, make sure there are serveral backup record is generated, and 


Please remove all the backup related codes from this PR. It should be another PR.

weekface · 2019-03-12T06:22:49Z

pkg/label/label.go

@@ -138,3 +140,25 @@ func (l Label) LabelSelector() *metav1.LabelSelector {
 func (l Label) Labels() map[string]string {
 	return l
 }
+
+//Labels convers label to string


// String converts label to a string

weekface · 2019-03-12T06:23:00Z

pkg/label/label.go

@@ -138,3 +140,25 @@ func (l Label) LabelSelector() *metav1.LabelSelector {
 func (l Label) Labels() map[string]string {
 	return l
 }
+
+//Labels convers label to string
+func (l Label) String() (string,error) {


func (l Label) String() string { var arr []string for k, v := range l { arr = append(arr, fmt.Sprintf("%s=%s", k, v)) } return strings.Join(arr, ",") }

weekface · 2019-03-12T06:34:55Z

tests/actions.go

@@ -228,10 +246,17 @@ func (oa *operatorActions) CleanTidbCluster(info *TidbClusterInfo) error {
 		}
 	}

-	resources := []string{"cronjobs", "jobs", "pods", "pvc"}
+	//for the test should add two clusters in a namespace, so we


delete these lines.

cwen0 · 2019-03-12T07:16:27Z

pkg/label/label.go

 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
+	"strings"


import ( "fmt" "strings" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/labels" )

format code

xiaojingchen · 2019-03-12T07:22:22Z

tests/actions.go

@@ -204,6 +212,10 @@ func (oa *operatorActions) DumpAllLogs(info *OperatorInfo, clusterInfo *TidbClus
 }

 func (oa *operatorActions) DeployTidbCluster(info *TidbClusterInfo) error {
+	glog.Infof("begin to deploy tidb cluster")


print more info about the cluster, like name and namespace

xiaojingchen · 2019-03-12T07:22:54Z

tests/actions.go

@@ -215,10 +227,13 @@ func (oa *operatorActions) DeployTidbCluster(info *TidbClusterInfo) error {
 }

 func (oa *operatorActions) CleanTidbCluster(info *TidbClusterInfo) error {
+	glog.Infof("begin to clean tidb cluster")


weekface

LGTM

tidb stability main func

shuijing198799 added 7 commits March 8, 2019 13:17

add ignore file and add bakcup test to the stability branch

4e9e00b

change parameter via the new yaml and value

ae77f56

scheduler yaml still has some argument so I need test backup and rest…

f73a3f5

…ore first

fix some bug and make the flow successful

3ad827d

fix some bug and make the flow successful

654ee35

fix some bug and avoid some path

7462197

delete commend line

e33d64b

tennix requested a review from weekface March 11, 2019 12:50

shuijing198799 changed the title ~~Backup~~ tidb stability test main function Mar 11, 2019

tennix requested review from tennix, zyguan and cwen0 March 11, 2019 12:51

delete comment and get yaml files

fb7d9cb

zyguan reviewed Mar 11, 2019

View reviewed changes

shuijing198799 added 2 commits March 12, 2019 10:38

delete some unready file and delete double dash and fix some bug intr…

08dd687

…oduce by zyguan

ignore a l in command

940d3dc

weekface reviewed Mar 12, 2019

View reviewed changes

shuijing198799 added 2 commits March 12, 2019 13:56

add label to string function and used in action

2f66d82

delete unuse functions

eed42f6

weekface reviewed Mar 12, 2019

View reviewed changes

delete more functions and modify the label function

3c20255

cwen0 reviewed Mar 12, 2019

View reviewed changes

modify the format and delete commend line

8541758

xiaojingchen reviewed Mar 12, 2019

View reviewed changes

xiaojingchen approved these changes Mar 12, 2019

View reviewed changes

weekface approved these changes Mar 12, 2019

View reviewed changes

weekface merged commit 129df4f into pingcap:stability Mar 12, 2019

shuijing198799 added a commit to shuijing198799/tidb-operator that referenced this pull request Mar 15, 2019

tidb stability test main function (pingcap#306)

d67fbd1

tidb stability main func

weekface pushed a commit to weekface/tidb-operator that referenced this pull request Mar 21, 2019

tidb stability test main function (pingcap#306)

ff6403a

tidb stability main func

tennix pushed a commit that referenced this pull request Mar 21, 2019

tidb stability test main function (#306)

59ebd4f

tidb stability main func

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tidb stability test main function #306

tidb stability test main function #306

shuijing198799 commented Mar 11, 2019 •

edited

Loading

CLAassistant commented Mar 11, 2019 •

edited

Loading

zyguan left a comment

zyguan Mar 11, 2019

zyguan Mar 11, 2019

shuijing198799 Mar 12, 2019

zyguan Mar 12, 2019

zyguan Mar 11, 2019

shuijing198799 Mar 12, 2019

zyguan Mar 11, 2019

zyguan Mar 11, 2019

weekface Mar 12, 2019

shuijing198799 Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

weekface Mar 12, 2019

cwen0 Mar 12, 2019

xiaojingchen Mar 12, 2019

xiaojingchen Mar 12, 2019

weekface left a comment

tidb stability test main function #306

tidb stability test main function #306

Conversation

shuijing198799 commented Mar 11, 2019 • edited Loading

CLAassistant commented Mar 11, 2019 • edited Loading

zyguan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

weekface left a comment

Choose a reason for hiding this comment

shuijing198799 commented Mar 11, 2019 •

edited

Loading

CLAassistant commented Mar 11, 2019 •

edited

Loading