stability: add fault-trigger server #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyguan
approved these changes
Mar 12, 2019
| data = stripEmpty(data) | ||
| lines := strings.Split(data, "\n") | ||
| for _, line := range lines { | ||
| if !strings.HasPrefix(line, "eth0") { |
There was a problem hiding this comment.
the interface name maybe not eth0.
There was a problem hiding this comment.
check the MAC address is exist is more reasonable
There was a problem hiding this comment.
https://github.com/pingcap/tidb-operator/pull/312/files#diff-cc0457c3ced0a4de0bcef6986b537b8aR72
if this check was failed, the program will check the mac address
weekface
reviewed
Mar 13, 2019
| func (m *Manager) StartETCD() error { | ||
| shell := "systemctl start etcd" | ||
| cmd := exec.Command("/bin/sh", "-c", shell) | ||
| _, err := cmd.CombinedOutput() |
There was a problem hiding this comment.
data, err := cmd.CombinedOutput()
if err != nil {
log.Errorf(".............")
}
?
xiaojingchen
approved these changes
Mar 13, 2019
|
@weekface @xiaojingchen PTAL again, thanks! |
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
* test: add fault-trigger server
tennix
pushed a commit
that referenced
this pull request
Mar 21, 2019
* test: add fault-trigger server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weekface @zyguan @xiaojingchen PTAL