add slack #318
Merged
add slack #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't matter much for this since it is just tests, but generally it is nice to publish messages to something like a Kafka queue and have a consumer publish them to Slack. That makes it easy for any other tooling to look at the events. That way only a single publisher need be written the tests and the Slack consumer can potentially be generic to publish from other tools as well. |
|
@gregwebs that's right, but at present, we use slack to notify, and support other tools is too expensive. |
Co-Authored-By: xiaojingchen <chenxiaojing141@gmail.com>
weekface
approved these changes
Mar 18, 2019
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
* add slack
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weekface @cwen0 @zyguan @shuijing198799 PTAL