stability: add blockWriter case for inserting data #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
reviewed
Mar 14, 2019
tests/actions.go
Outdated
| @@ -28,6 +28,8 @@ import ( | |||
| "github.com/pingcap/tidb-operator/pkg/client/clientset/versioned" | |||
| "github.com/pingcap/tidb-operator/pkg/controller" | |||
| "github.com/pingcap/tidb-operator/pkg/label" | |||
| "github.com/pingcap/tidb-operator/tests/pkg/blockWriter" | |||
There was a problem hiding this comment.
blockWriter -> blockwriter ?
tests/pkg/blockWriter/blockWriter.go
Outdated
| case <-c.stopChan: | ||
| glog.Infof("[%s] stoping...", c) | ||
| cancel() | ||
| wg.Wait() |
There was a problem hiding this comment.
add wg.Wait() to this block is strange.
|
@cwen0 fix the conflicts. |
|
@weekface PTAL again, thanks! |
weekface
approved these changes
Mar 18, 2019
|
@xiaojingchen PTAL |
xiaojingchen
approved these changes
Mar 18, 2019
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
* add blockWriter case to insert data
tennix
pushed a commit
that referenced
this pull request
Mar 21, 2019
* add blockWriter case to insert data
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* fix tls doc * update format Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weekface @zyguan @xiaojingchen @shuijing198799 PTAL