Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Ratio and Proportion 1.2.0-rc.2 #863

Closed
15 tasks done
zepumph opened this issue Dec 5, 2022 · 7 comments
Closed
15 tasks done

RC Test: Ratio and Proportion 1.2.0-rc.2 #863

zepumph opened this issue Dec 5, 2022 · 7 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Dec 5, 2022

RC Test

Mentions: @emily-phet @terracoda @BLFiedler

Simulation links

Test Matrix

Features included

Focus and Special Instructions

Please note that we have dropped PhET-iO support for this release. Important features for testing are camera input: hands, and voicing, and especially how they interact together.

RC.1 was stopped pre-maturely due to many issues found. So please do a full RC test.

Issues to Verify

These issues should have the "status:ready-for-cherry-pick". Please feel free to close any all issues below if you cannot reproduce the bug.


For QA...

General features

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Test the Game Up harness on at least one platform.
  • Check this LoL
    spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version.
  • Try to include version numbers for browsers.
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.
  • As the RC ends, please review the QA credits in the about dialog. If the QA credits are complete and correct, please add a comment in the RC test issue indicating so. If not, please open a new issue and specify what changes should be made.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).
  • If this sim is not in this list or up to date there, make an
    issue in website to ask if PhET research page links need updating. Please
    assign to @terracoda and @emily-phet.

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 8, 2022

Memory test:
memory

@zepumph
Copy link
Member Author

zepumph commented Dec 8, 2022

@KatieWoe for extra knowledge building and sharing, dialogs are created lazily, so quite often the best way to test for memory leaks it to compare to the snapshot after you have created the preferences, keyboard help, and about dialogs. Below is 2 snapshots, one on startup, and the other after creating dialogs, so in fact a large portion of the memory increase is just from the space that created dialogs take up.

image

@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 8, 2022

I know. I don't think there's anything wrong with these snapshots. Just recording here that the tests were done and what the results were.

@Nancy-Salpepi
Copy link
Contributor

Noting that: For Voicing on macOS 10.15.7 + safari 15.6.1 when I change the voice the name changes, but the voice stays the same (always 'Alex' Voice). This doesn’t happen on the recent versions of macOS or iPadOS or with macOS 10.15.7 + chrome…so I am assuming it is a safari problem that got fixed. It also happens in published GFLB and JT.
Let me know if you think it is worthy of an issue @zepumph (utterance queue?).

@zepumph
Copy link
Member Author

zepumph commented Dec 14, 2022

Thanks @Nancy-Salpepi. @emily-phet and I do not think this is worth investigation unless it appears in the latest versions (OS13).

@KatieWoe
Copy link
Contributor

Calling QA here

@KatieWoe KatieWoe assigned zepumph and unassigned KatieWoe Dec 14, 2022
@zepumph
Copy link
Member Author

zepumph commented Jan 3, 2023

we'll pick this up in #874. THanks all!

@zepumph zepumph closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants