Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voicing says "Property Number" before each item in keyboard nav dialog #525

Closed
Tracked by #863
Nancy-Salpepi opened this issue Nov 15, 2022 · 4 comments
Closed
Tracked by #863

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air m1 chip

Operating System
13.0.1

Browser
safari and chrome

Problem description
For phetsims/qa#852, before each item in the keyboard dialog, voicing says "property number ...."

Steps to reproduce

  1. Turn on Voicing
  2. Open Keyboard Nav dialog
  3. Click on or tab to any section.

Visuals

propertynumber.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.1/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-rc.1 2022-11-11 22:40:36 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Language: en-US Window: 1544x712 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@zepumph
Copy link
Member

zepumph commented Nov 23, 2022

Good catch, noting phetsims/scenery-phet#769 here because that is where this showed up. It would be best to fully support this with a patternStringProperty, but this commit will be best to cherry pick. I'll note over in the other issue to ensure a more thorough solution.

@zepumph
Copy link
Member

zepumph commented Nov 23, 2022

Cherry pick: the above 2 commits!

@zepumph zepumph removed their assignment Nov 23, 2022
@zepumph
Copy link
Member

zepumph commented Dec 5, 2022

Done and ready for confirmation in next version.

@Nancy-Salpepi
Copy link
Author

This looks good in 1.2.0-rc.2 with mac + safari/chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants