Voicing reads combo box in a previously used locale

[stemilymill]

For phetsims/qa#852

Test device
Dell laptop

Operating System
Win10 21H2

Browser
Chrome 107.0.5304.107

Problem description
With voicing enabled, I was switching between different locales and using keynav. When I had switched from Danish to English, and shift+tabbed back to play with the hands, voicing read over "Challenge 3" (which was currently selected in the combo box) as "Opgave 3" with 3 as english three and Opgave in an English pronunciation.

When I entered the combo box, voicing read everything as expected, including "Challenge 3."

Steps to reproduce
I am still working on this. After recording the video below I changed the locale to German and then back to English and the self-voicing behaved as normally expected.

Visuals

voicing.reading.danish.translated.string.mp4

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Ratio and Proportion‬
URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.1/phet/ratio-and-proportion_all_phet.html
Version: 1.2.0-rc.1 2022-11-11 22:40:36 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
Language: en-US
Window: 1493x775
Pixel Ratio: 1.125/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

[zepumph]

Voicing is an "english only" feature, so this bug is actually that voicing doesn't turn off when switching locale. I'll take a look.

[Nancy-Salpepi]

@zepumph voicing seems to be working correctly with mac + safari/chrome. With Voicing enabled, when I switch locale it becomes disabled and I hear "Voicing off. Only available in English."

[Nancy-Salpepi]

Also not seeing this issue with the Chromebook.

[stemilymill]

when the locale was danish, voicing was actually correctly disabled, but when I switched back to english and voicing was re-enabled everything except the combo box was being read correctly

[Nancy-Salpepi]

Thanks for the clarification @stemilymill!
I was able to reproduce with the mac and with Chromebook using these steps @zepumph:

Steps:

1. Enable Voicing
2. In the Localization tab, change the locale to Dansk or any other language --Voicing becomes disabled
3. Exit the dialog
4. On the Discover Screen, change the Challenge--ex. Pick Challenge 2
5. Change the locale back to English --Voicing becomes enabled
6. Exit dialog and tab to the Combobox --The current challenge will be read in Dansk.
7. Open the combo box--Voicing is in English.

[zepumph]

Wonderful. You are seriously talented folks. Thanks! I also found the same issue with voicing name response for the combo box list items.

To cherry pick: phetsims/sun@ddb0240

[zepumph]

Done and ready for confirmation in next version.

[KatieWoe]

This looks good in rc.2

[Nancy-Salpepi]

This seems to still be broken in rc.2 with the keyboard dialog this time.

Steps:

1. Turn on Voicing
2. Switch to another locale--ex Italian (voicing turns off)
3. Open the keyboard dialog
4. Switch back to English (voicing turns back on)
5. Open the keyboard dialog and tab through--it will be a combination of English words and the English voice pronouncing the Italian words.

Italian2.mov

[zepumph]

Excellent! I can reproduce in rc.2 but not on master. I believe it to be because of phetsims/scenery-phet@005be16 which I thought wouldn't matter for RAP, oops. I can cherry pick that into the rc, but first will you confirm that it is not reproducible on master please?

[Nancy-Salpepi]

I can't reproduce on master either. yay.

[zepumph]

Wonderful!

[zepumph]

I'll cherry pick phetsims/scenery-phet@005be16 but I will also make sure that fixes it and doesn't need any other changes from that monster issue.

[zepumph]

I also had to cherry pick phetsims/axon@2e738ee also. But now it is all cherry picked. Cherry picked. QA, feel free to close if all is well.

[Nancy-Salpepi]

Looks good in 1.2.0-rc.3! Closing