Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Spot-Check Test: Ratio And Proportion 1.2.0-rc.3 #874

Closed
12 of 15 tasks
zepumph opened this issue Jan 3, 2023 · 9 comments
Closed
12 of 15 tasks

RC Spot-Check Test: Ratio And Proportion 1.2.0-rc.3 #874

zepumph opened this issue Jan 3, 2023 · 9 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jan 3, 2023

RC Spot-Check Test

Mentions: @emily-phet @terracoda @BLFiedler

Simulation links

Test Matrices

General Test:

  • Tester = NS , Platform = macOS 13.0.1 + safari 16.1 , Time = 1hr
  • Tester = KW, Platform = Win 11 Chrome, Time = .75

Additional Features Test:

  • Tester = , Platform = , Time =
  • Tester = , Platform = , Time =

Features included

  • PhET-iO
  • Alternative Input
  • UI Sound
  • Sonification
  • Description
  • Voicing

Focus and Special Instructions

Issues to Verify

These issues should have the "status:ready-for-cherry-pick" label. Please feel free to close all below if they look good.


For QA...

General features

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test some query parameters. (See QA Book for a list of query parameters.)
  • When making an issue, check to see if it was in a previously published version.
  • Try to include version numbers for browsers.
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.
  • As the RC ends, notify the developer of any new QA credits that need to be added.

PhET-iO features

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.
  • Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:
    /wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER
    
    Further instructions in QA Book
  • Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
    random platform.
  • Conduct a memory test on the stand alone sim wrapper (rc.1).
  • Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
  • If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
  • Test that the sim works offline:
    • Click the link to the phet-io zip file (at top of issue) to download the zip file.
    • Unzip it to a spot locally.
    • Open index.html by double clicking it on your desktop or in a Finder-view.
    • It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).
  • If this sim is not in this list or up to date there, make an
    issue in website to ask if PhET research page links need updating. Please
    assign to @terracoda and @emily-phet.

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 4, 2023

I noticed that some things in voicing, such as some of the "helpful hints" only show up if using keyboard, not with mouse. Is this known/intended?

@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2023

Can you be specific? My guess is that it is a bug.

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 4, 2023

If you turn on helpful hints and keyboard nav focus on the ratio lock button, it will tell you what the button does. Hovering with the mouse or clicking on it does not give the same information. Things like that.

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 4, 2023

QA is done. Let me know if you want an issue for #874 (comment)

@KatieWoe KatieWoe assigned zepumph and unassigned KatieWoe Jan 4, 2023
@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2023

If you turn on helpful hints and keyboard nav focus on the ratio lock button, it will tell you what the button does. Hovering with the mouse or clicking on it does not give the same information. Things like that.

Ahh right, @jessegreenberg and spoke briefly about this. Yes thanks for confirming, it really is inherent to the design. We decided early on in the voicing process that we wouldn't give content on hover. As a result, there is no parallel in mouse land to the "focus" keyboard event, and so we have to limit the content with mouse to just activation (and often keep hints out of that response).

Thanks QA! You rock.

@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2023

@KatieWoe, just for my information, would you please explain why the "Additional Features Test:" checkboxes are blank, and when they would be used for an RC spot check?

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 4, 2023

We tested the additional features while testing everything else. Since RAP is so designed around those features we didn't really separate them. That section is mostly for if a "general" version and a version with more features both need a fair amount of testing. Sorry for the confusion.

@zepumph
Copy link
Member Author

zepumph commented Jan 4, 2023

No confusion here! Thanks for explaining.

zepumph added a commit to phetsims/ratio-and-proportion that referenced this issue Jan 4, 2023
@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 4, 2023

Closing since rc.4 is out

@KatieWoe KatieWoe closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants