Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I hear tick mark bump AND boundary sound #536

Closed
Tracked by #863
zepumph opened this issue Nov 24, 2022 · 3 comments
Closed
Tracked by #863

I hear tick mark bump AND boundary sound #536

zepumph opened this issue Nov 24, 2022 · 3 comments
Labels
status:ready-to-cherry-pick

Comments

@zepumph
Copy link
Member

zepumph commented Nov 24, 2022

To reproduce:

  • first screen
  • Show tick marks
  • Use the keyboard
  • highlight consequent and move in large steps to the bottom value.
  • When reaching zero, I hear a tick mark bump on key down, and a boundary sound on key up.

This is a bug.
zepumph added a commit that referenced this issue Nov 24, 2022
@zepumph
boolean bug fix, for #536
444859d
@zepumph
Copy link
Member Author

zepumph commented Nov 24, 2022

To cherry pick: 444859d

@zepumph
Copy link
Member Author

zepumph commented Dec 5, 2022

Done and ready for confirmation in next version.

zepumph added a commit that referenced this issue Dec 5, 2022
@zepumph
boolean bug fix, for #536
115d3de
@zepumph zepumph mentioned this issue Dec 5, 2022
Closed
15 tasks
@zepumph
Copy link
Member Author

zepumph commented Dec 7, 2022

@KatieWoe just showed me that this bug wasn't present on rc.1, so I guess somehow it was only on master 2 weeks ago? Not sure, but I'm still glad for the bug fix. Closing

@zepumph zepumph closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-to-cherry-pick
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph