Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VoiceOver] "Range" is spoken twice when it has focus #532

Closed
Tracked by #863
Nancy-Salpepi opened this issue Nov 18, 2022 · 9 comments
Closed
Tracked by #863

[VoiceOver] "Range" is spoken twice when it has focus #532

Nancy-Salpepi opened this issue Nov 18, 2022 · 9 comments
Assignees

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
13.0.1

Browser
safari 16.1

Problem description
With VoiceOver, when I tab to the range combobox, "range" is said twice. It also happens when closing the combobox.

Steps to reproduce

  1. Turn on VoiceOver
  2. Tab to and select (numbered) tick marks
  3. Tab to Range Combobox--you should here "range" repeated
  4. Change the range to something else and press return--it will be repeated here too

Visuals

rangerange.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.1/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-rc.1 2022-11-11 22:40:36 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Language: en-US Window: 1544x712 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@zepumph
Copy link
Member

zepumph commented Nov 24, 2022

The way this issue is described, it seems obvious and easy to reproduce. I was not able to see it on my windows machine, so I'm wondering if you could test this on master to make sure it is still as broken as it sounds. We have made a couple other changes that could have effected this.

@zepumph zepumph assigned Nancy-Salpepi and unassigned zepumph Nov 24, 2022
@Nancy-Salpepi
Copy link
Author

@zepumph I see this issue on master. Perhaps it is specific to VoiceOver + safari? You said you were on a Windows machine.

@zepumph
Copy link
Member

zepumph commented Nov 30, 2022

I'll try to reproduce on my iOS+ safari, and then solicit help if I need a mac. @emily-phet and I agree that so long as we understand what is happening, and it seems minor, if we can't fix it is ok to proceed.

@zepumph
Copy link
Member

zepumph commented Dec 2, 2022

@marlitas and I went to town on this issue, and found that when the ComboBoxButton labelTagName is a p, the there is no issue with duplication. I felt like it was a pretty slight change for that fact that it fixed this bug, but it definitely is a workaround since safari+VO is the only spot where this is an issue.

@jessegreenberg do you think this is acceptable? I'm happy to discuss if you have concerns, but please assign back to me.

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Dec 2, 2022
zepumph added a commit to phetsims/sun that referenced this issue Dec 3, 2022
@zepumph
Copy link
Member

zepumph commented Dec 5, 2022

Done and ready for confirmation in next version.

@jessegreenberg
Copy link
Contributor

I can't think why this would be an issue. I also don't know why it was previously a span. Seems good to move forward with and hopefully this change will will work for all screen readers.

@zepumph zepumph removed their assignment Dec 7, 2022
@Nancy-Salpepi
Copy link
Author

Things sound good in 1.2.0-rc.2 with VoiceOver + safari on the mac, but a little weird on the iPad. 'Range' is said once in a swipe (with a different voice). Then you have to swipe again. It again says 'Range' in a different voice before stating the range.

rangerange.mov

Here is what it sounds like on the mac:

rangeonmac.mov

@zepumph
Copy link
Member

zepumph commented Dec 7, 2022

After discussing with @jessegreenberg, we are totally fine with this behavior. Thanks! Closing

@zepumph zepumph closed this as completed Dec 7, 2022
@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 7, 2022

Noting that I'm seeing this with Jaws + Chrome as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants