-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VoiceOver] "Range" is spoken twice when it has focus #532
Comments
The way this issue is described, it seems obvious and easy to reproduce. I was not able to see it on my windows machine, so I'm wondering if you could test this on master to make sure it is still as broken as it sounds. We have made a couple other changes that could have effected this. |
@zepumph I see this issue on master. Perhaps it is specific to VoiceOver + safari? You said you were on a Windows machine. |
I'll try to reproduce on my iOS+ safari, and then solicit help if I need a mac. @emily-phet and I agree that so long as we understand what is happening, and it seems minor, if we can't fix it is ok to proceed. |
@marlitas and I went to town on this issue, and found that when the ComboBoxButton labelTagName is a @jessegreenberg do you think this is acceptable? I'm happy to discuss if you have concerns, but please assign back to me. |
Done and ready for confirmation in next version. |
I can't think why this would be an issue. I also don't know why it was previously a span. Seems good to move forward with and hopefully this change will will work for all screen readers. |
Things sound good in 1.2.0-rc.2 with VoiceOver + safari on the mac, but a little weird on the iPad. 'Range' is said once in a swipe (with a different voice). Then you have to swipe again. It again says 'Range' in a different voice before stating the range. rangerange.movHere is what it sounds like on the mac: rangeonmac.mov |
After discussing with @jessegreenberg, we are totally fine with this behavior. Thanks! Closing |
Noting that I'm seeing this with Jaws + Chrome as well. |
Test device
MacBook Air (m1 chip)
Operating System
13.0.1
Browser
safari 16.1
Problem description
With VoiceOver, when I tab to the range combobox, "range" is said twice. It also happens when closing the combobox.
Steps to reproduce
Visuals
rangerange.mov
The text was updated successfully, but these errors were encountered: