Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Excavator: Upgrades Baseline to the latest version #92

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 7, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.29.0

Type Description Link
Improvement Error prone RedundantModifier check supports interface static methods and fields. palantir/gradle-baseline#1021
Fix Ignore module-info.java files to support projects with Jigsaw. palantir/gradle-baseline#1023
Improvement Error Prone StrictCollectionIncompatibleType to guard collection usage palantir/gradle-baseline#1027
Improvement Drop RedundantModifier to SUGGESTION and FinalClass to WARNING

These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
palantir/gradle-baseline#1028

2.30.0

Type Description Link
Improvement InvocationHandlers which delegate to another object must catch and unwrap
InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown
each time the delegate throws an exception.
palantir/gradle-baseline#1032

2.31.0

Type Description Link
Improvement Add a refaster rule to migrate InvocationTargetException.getTargetException to getCause. palantir/gradle-baseline#1039
Fix Fix using errorprone when running under Windows. palantir/gradle-baseline#1045

2.32.0

Type Description Link
Fix Checkstyle no longer complains about single-line javadoc produced by palantir-java-format. palantir/gradle-baseline#1051
Improvement PreferAssertj disallows assert statements in test code.

Tests should use more specific AssertJ checks, which cannot be disabled by turning off asserts. Arguably the assert keyword should never be used, preferring preconditions. This way production environments cannot reach code paths that are impossible to test.
palantir/gradle-baseline#1052

2.33.0

Type Description Link
Improvement Implement Slf4jThrowable check to ensure throwable args are logged last palantir/gradle-baseline#1054

2.34.0

Type Description Link
Improvement Adds an ErrorProne rule, JooqResultStreamLeak, which ensures that result streams and cursors returned from jOOQ results are closed in a try-with-resources block. palantir/gradle-baseline#1055

2.35.0

Type Description Link
Improvement Refaster rule to remove unnecessary supplier creation palantir/gradle-baseline#1059
Improvement Add Refaster rule to convert Stream.of() -> Stream.empty() palantir/gradle-baseline#1061

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from b55c59a to 9f5c824 Compare November 15, 2019 20:53
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from bd84a6a to 8ebead4 Compare November 19, 2019 22:00
@tstearns tstearns merged commit 1ca8616 into master Nov 20, 2019
@tstearns tstearns deleted the roomba/latest-baseline-oss branch November 20, 2019 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants