Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Java 9 module-info.java #1023

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Exclude Java 9 module-info.java #1023

merged 3 commits into from
Nov 5, 2019

Conversation

raiju
Copy link
Contributor

@raiju raiju commented Nov 5, 2019

Before this PR

Running checkstyle on repositories with Java 9 modules fails

After this PR

==COMMIT_MSG==

Ignore module-info.java files to support projects with Jigsaw.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Nov 5, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Ignore module-info.java files to support projects with Jigsaw.

Check the box to generate changelog(s)

  • Generate changelog entry

@@ -53,6 +53,9 @@
<property name="optional" value="true"/>
</module>
<module name="SuppressWarningsFilter"/> <!-- baseline-gradle: README.md -->
<module name="BeforeExecutionExclusionFileFilter">
<property name="fileNamePattern" value="module\-info\.java$"/>
</module>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdanfox
Copy link
Contributor

iamdanfox commented Nov 5, 2019

Looks plausible to me 👍 - have you tried this locally and seen checkstyleMain pass?

@bulldozer-bot bulldozer-bot bot merged commit 9f9a013 into develop Nov 5, 2019
@bulldozer-bot bulldozer-bot bot deleted the raiju-patch-1 branch November 5, 2019 19:03
@raiju
Copy link
Contributor Author

raiju commented Nov 5, 2019

Yes, I've already made this change locally, which fixed CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants