Add JooqResultStreamLeak ErrorProne rule #1055
Conversation
Generate changelog in
|
| } | ||
|
|
||
| private static boolean isStreamOrCursor(MethodInvocationTree tree, VisitorState state) { | ||
| boolean isStream = ASTHelpers.isSubtype(ASTHelpers.getReturnType(tree), |
There was a problem hiding this comment.
nit: could factor out ASTHelpers.getReturnType(tree) and call it once.
Actually, could we replace the checks for either Stream or Cursor with a single check for AutoCloseable which covers both cases (and any potential future types)?
| link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", | ||
| linkType = BugPattern.LinkType.CUSTOM, | ||
| providesFix = BugPattern.ProvidesFix.REQUIRES_HUMAN_ATTENTION, | ||
| severity = BugPattern.SeverityLevel.ERROR, |
There was a problem hiding this comment.
Mind if we bump this down to a warning for the initial rollout? We can bump it up after we're confident it does exactly what we want.
| CompilationTestHelper.newInstance(JooqResultStreamLeak.class, getClass()); | ||
|
|
||
| private final BugCheckerRefactoringTestHelper refactoringTestHelper = | ||
| BugCheckerRefactoringTestHelper.newInstance(new JooqResultStreamLeak(), getClass()); |
There was a problem hiding this comment.
one more nit: mind using our RefactoringValidator instead of BugCheckerRefactoringTestHelper? Ours validates that the refactored result also passes validation
|
Released 2.34.0 |
After this PR
==COMMIT_MSG==
Adds an ErrorProne rule,
JooqResultStreamLeak, which ensures that result streams and cursors returned from jOOQ results are closed in a try-with-resources block.==COMMIT_MSG==