-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Prone InvocationHandlerDelegation to ensure proxies handle delegate exceptions. #1032
Conversation
Generate changelog in
|
I'll report back here once I've verified this on a large internal repo. |
This doesn't handle the cases:
Though they're unnecessarily difficult to read, I don't want to cause friction for implementations that aren't actually broken. |
…gate exceptions. InvocationHandlers which delegate to another object must catch and unwrap InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown each time the delegate throws an exception.
b43fc02
to
508121d
Compare
Verified in a large internal project (where it discovered four instances of the bug) |
Released 2.30.0 |
==COMMIT_MSG==
InvocationHandlers which delegate to another object must catch and unwrap
InvocationTargetException
, otherwise anUndeclaredThrowableException
will be throwneach time the delegate throws an exception.
==COMMIT_MSG==