Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1053 Implement Slf4jThrowable check to ensure throwable args are logged last #1054

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Nov 18, 2019

fix #1053
==COMMIT_MSG==
Implement Slf4jThrowable check to ensure throwable args are logged last
==COMMIT_MSG==

Possible downsides?

If folks are logging exceptions expecting the string value, they will get warnings. We don't recommend logging exceptions without a stack trace because we lose the most helpful information.

@changelog-app
Copy link

changelog-app bot commented Nov 18, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Implement Slf4jThrowable check to ensure throwable args are logged last

Check the box to generate changelog(s)

  • Generate changelog entry

@ferozco
Copy link
Contributor

ferozco commented Nov 18, 2019

👍

@svc-autorelease
Copy link
Collaborator

Released 2.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorProne Check for Log Arg Ordering
3 participants