-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default explore topic matches user interest #930
Conversation
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
β Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shamimbinnur if the user has multiple interests, maybe we should pick the first one. Check the screenshot below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll need to hook this into the user settings being updated also, but separate from this
π This PR is included in version 1.31.0-beta.15 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.32.0-beta.1](v1.31.0...v1.32.0-beta.1) (2023-03-02) ### π Features * add ability to delete an insight page ([#920](#920)) ([e1cd798](e1cd798)), closes [#853](#853) * add loading state to highlight cards ([#921](#921)) ([63c2cc1](63c2cc1)), closes [#903](#903) * default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929) * implement highlights feed page ([#913](#913)) ([6271c91](6271c91)), closes [#900](#900) [#829](#829) * navigate to user contributions tab if there are no user highlights ([#918](#918)) ([3bb20ef](3bb20ef)), closes [#914](#914) [#916](#916) * update default user profile bio ([#926](#926)) ([2a95817](2a95817)), closes [#922](#922)
π This PR is included in version 1.32.0-beta.1 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.32.0](v1.31.0...v1.32.0) (2023-03-02) ### π Features * add ability to delete an insight page ([#920](#920)) ([e1cd798](e1cd798)), closes [#853](#853) * add loading state to highlight cards ([#921](#921)) ([63c2cc1](63c2cc1)), closes [#903](#903) * default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929) * implement highlights feed page ([#913](#913)) ([6271c91](6271c91)), closes [#900](#900) [#829](#829) * navigate to user contributions tab if there are no user highlights ([#918](#918)) ([3bb20ef](3bb20ef)), closes [#914](#914) [#916](#916) * update default user profile bio ([#926](#926)) ([2a95817](2a95817)), closes [#922](#922)
π This PR is included in version 1.32.0 π The release is available on GitHub release Your semantic-release bot π¦π |
@brandonroberts I just noticed this line has not been updated. Was it intentional? |
@shamimbinnur it was not intentional. It got changed accidentally while resolving some merge conflicts. It needs to be reapplied |
You can add it to #939 |
## [1.33.0-beta.1](v1.32.0...v1.33.0-beta.1) (2023-03-03) ### π Bug Fixes * broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937) ### π Features * expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930)
π This issue has been resolved in version 1.33.0-beta.1 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.33.0](v1.32.0...v1.33.0) (2023-03-07) ### π Bug Fixes * broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937) * Add highlights placeholder ([#945](#945)) ([034d550](034d550)) * check for contributor commit data before updating graph ([#941](#941)) ([58a74fe](58a74fe)) * Highlights UX copy bandaid ([#944](#944)) ([8a7d559](8a7d559)) * keep initial user settings data after being fetched ([#959](#959)) ([b869863](b869863)), closes [#931](#931) ### π§βπ» Code Refactoring * update non-connected user avatar ([#967](#967)) ([51bf664](51bf664)), closes [#964](#964) ### π Features * add repository search to the create insights page ([#958](#958)) ([d6f151c](d6f151c)), closes [#932](#932) * add reuseable error component to the design system ([#954](#954)) ([56e986b](56e986b)), closes [#781](#781) [#700](#700) * expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930) * make highlights avatar and handle clickable on feeds page ([#953](#953)) ([fd59918](fd59918)), closes [#940](#940) [#935](#935) * make the entire insight page buttons clickable ([#960](#960)) ([7a7708f](7a7708f)), closes [#701](#701) * make user profile interest clickable ([#952](#952)) ([370bc8a](370bc8a)), closes [#942](#942)
π This issue has been resolved in version 1.33.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.31.0-beta.15](open-sauced/app@v1.31.0-beta.14...v1.31.0-beta.15) (2023-03-01) ### π Features * default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929)
## [1.32.0-beta.1](open-sauced/app@v1.31.0...v1.32.0-beta.1) (2023-03-02) ### π Features * add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853) * add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903) * default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929) * implement highlights feed page ([#913](open-sauced/app#913)) ([6271c91](open-sauced/app@6271c91)), closes [#900](open-sauced/app#900) [#829](open-sauced/app#829) * navigate to user contributions tab if there are no user highlights ([#918](open-sauced/app#918)) ([3bb20ef](open-sauced/app@3bb20ef)), closes [#914](open-sauced/app#914) [#916](open-sauced/app#916) * update default user profile bio ([#926](open-sauced/app#926)) ([2a95817](open-sauced/app@2a95817)), closes [#922](open-sauced/app#922)
## [1.32.0](open-sauced/app@v1.31.0...v1.32.0) (2023-03-02) ### π Features * add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853) * add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903) * default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929) * implement highlights feed page ([#913](open-sauced/app#913)) ([6271c91](open-sauced/app@6271c91)), closes [#900](open-sauced/app#900) [#829](open-sauced/app#829) * navigate to user contributions tab if there are no user highlights ([#918](open-sauced/app#918)) ([3bb20ef](open-sauced/app@3bb20ef)), closes [#914](open-sauced/app#914) [#916](open-sauced/app#916) * update default user profile bio ([#926](open-sauced/app#926)) ([2a95817](open-sauced/app@2a95817)), closes [#922](open-sauced/app#922)
## [1.33.0-beta.1](open-sauced/app@v1.32.0...v1.33.0-beta.1) (2023-03-03) ### π Bug Fixes * broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937) ### π Features * expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930)
## [1.33.0](open-sauced/app@v1.32.0...v1.33.0) (2023-03-07) ### π Bug Fixes * broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937) * Add highlights placeholder ([#945](open-sauced/app#945)) ([034d550](open-sauced/app@034d550)) * check for contributor commit data before updating graph ([#941](open-sauced/app#941)) ([58a74fe](open-sauced/app@58a74fe)) * Highlights UX copy bandaid ([#944](open-sauced/app#944)) ([8a7d559](open-sauced/app@8a7d559)) * keep initial user settings data after being fetched ([#959](open-sauced/app#959)) ([b869863](open-sauced/app@b869863)), closes [#931](open-sauced/app#931) ### π§βπ» Code Refactoring * update non-connected user avatar ([#967](open-sauced/app#967)) ([51bf664](open-sauced/app@51bf664)), closes [#964](open-sauced/app#964) ### π Features * add repository search to the create insights page ([#958](open-sauced/app#958)) ([d6f151c](open-sauced/app@d6f151c)), closes [#932](open-sauced/app#932) * add reuseable error component to the design system ([#954](open-sauced/app#954)) ([56e986b](open-sauced/app@56e986b)), closes [#781](open-sauced/app#781) [#700](open-sauced/app#700) * expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930) * make highlights avatar and handle clickable on feeds page ([#953](open-sauced/app#953)) ([fd59918](open-sauced/app@fd59918)), closes [#940](open-sauced/app#940) [#935](open-sauced/app#935) * make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701) * make user profile interest clickable ([#952](open-sauced/app#952)) ([370bc8a](open-sauced/app@370bc8a)), closes [#942](open-sauced/app#942)
What type of PR is this? (check all applicable)
Description
I fetched the value of the user's interests from the database using
useFetchUser()
, which indicates the language they are interested in and set it as their default topic.Related Tickets & Documents
Fixes #929
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?