Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default explore topic matches user interest #930

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

shamimbinnur
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

I fetched the value of the user's interests from the database using useFetchUser(), which indicates the language they are interested in and set it as their default topic.

Related Tickets & Documents

Fixes #929

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Mar 1, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit c9c16ae
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63ff77c5d91ded000834bae9
😎 Deploy Preview https://deploy-preview-930--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 1, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit c9c16ae
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63ff77c5afbb5c0008370ece
😎 Deploy Preview https://deploy-preview-930--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shamimbinnur shamimbinnur marked this pull request as ready for review March 1, 2023 14:44
@shamimbinnur shamimbinnur changed the title topic based on user interest feat: default explore topic matches user interest Mar 1, 2023
Copy link
Contributor

@takanome-dev takanome-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamimbinnur if the user has multiple interests, maybe we should pick the first one. Check the screenshot below

Screenshot from 2023-03-01 15-06-50

components/organisms/TopNav/top-nav.tsx Outdated Show resolved Hide resolved
@bdougie
Copy link
Member

bdougie commented Mar 1, 2023

It tries to add all topics. Should just grab the first.

Screen Shot 2023-03-01 at 7 07 29 AM

Copy link
Contributor

@takanome-dev takanome-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll need to hook this into the user settings being updated also, but separate from this

@brandonroberts brandonroberts merged commit e73c9dd into open-sauced:beta Mar 1, 2023
github-actions bot pushed a commit that referenced this pull request Mar 1, 2023
## [1.31.0-beta.15](v1.31.0-beta.14...v1.31.0-beta.15) (2023-03-01)

### πŸ• Features

* default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

πŸŽ‰ This PR is included in version 1.31.0-beta.15 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Mar 2, 2023
## [1.32.0-beta.1](v1.31.0...v1.32.0-beta.1) (2023-03-02)

### πŸ• Features

* add ability to delete an insight page ([#920](#920)) ([e1cd798](e1cd798)), closes [#853](#853)
* add loading state to highlight cards ([#921](#921)) ([63c2cc1](63c2cc1)), closes [#903](#903)
* default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929)
* implement highlights feed page ([#913](#913)) ([6271c91](6271c91)), closes [#900](#900) [#829](#829)
* navigate to user contributions tab if there are no user highlights ([#918](#918)) ([3bb20ef](3bb20ef)), closes [#914](#914) [#916](#916)
* update default user profile bio ([#926](#926)) ([2a95817](2a95817)), closes [#922](#922)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

πŸŽ‰ This PR is included in version 1.32.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Mar 2, 2023
## [1.32.0](v1.31.0...v1.32.0) (2023-03-02)

### πŸ• Features

* add ability to delete an insight page ([#920](#920)) ([e1cd798](e1cd798)), closes [#853](#853)
* add loading state to highlight cards ([#921](#921)) ([63c2cc1](63c2cc1)), closes [#903](#903)
* default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929)
* implement highlights feed page ([#913](#913)) ([6271c91](6271c91)), closes [#900](#900) [#829](#829)
* navigate to user contributions tab if there are no user highlights ([#918](#918)) ([3bb20ef](3bb20ef)), closes [#914](#914) [#916](#916)
* update default user profile bio ([#926](#926)) ([2a95817](2a95817)), closes [#922](#922)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

πŸŽ‰ This PR is included in version 1.32.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@shamimbinnur
Copy link
Contributor Author

@brandonroberts I just noticed this line has not been updated. Was it intentional?

@brandonroberts
Copy link
Contributor

brandonroberts commented Mar 3, 2023

@shamimbinnur it was not intentional. It got changed accidentally while resolving some merge conflicts. It needs to be reapplied

@brandonroberts
Copy link
Contributor

You can add it to #939

brandonroberts pushed a commit that referenced this pull request Mar 3, 2023
github-actions bot pushed a commit that referenced this pull request Mar 3, 2023
## [1.33.0-beta.1](v1.32.0...v1.33.0-beta.1) (2023-03-03)

### πŸ› Bug Fixes

*  broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937)

### πŸ• Features

* expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

πŸŽ‰ This issue has been resolved in version 1.33.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Mar 7, 2023
## [1.33.0](v1.32.0...v1.33.0) (2023-03-07)

### πŸ› Bug Fixes

*  broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937)
* Add highlights placeholder ([#945](#945)) ([034d550](034d550))
* check for contributor commit data before updating graph ([#941](#941)) ([58a74fe](58a74fe))
* Highlights UX copy bandaid ([#944](#944)) ([8a7d559](8a7d559))
* keep initial user settings data after being fetched ([#959](#959)) ([b869863](b869863)), closes [#931](#931)

### πŸ§‘β€πŸ’» Code Refactoring

* update non-connected user avatar  ([#967](#967)) ([51bf664](51bf664)), closes [#964](#964)

### πŸ• Features

* add repository search to the create insights page ([#958](#958)) ([d6f151c](d6f151c)), closes [#932](#932)
* add reuseable error component to the design system ([#954](#954)) ([56e986b](56e986b)), closes [#781](#781) [#700](#700)
* expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930)
* make highlights avatar and handle clickable on feeds page ([#953](#953)) ([fd59918](fd59918)), closes [#940](#940) [#935](#935)
* make the entire insight page buttons clickable ([#960](#960)) ([7a7708f](7a7708f)), closes [#701](#701)
* make user profile interest clickable ([#952](#952)) ([370bc8a](370bc8a)), closes [#942](#942)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

πŸŽ‰ This issue has been resolved in version 1.33.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.31.0-beta.15](open-sauced/app@v1.31.0-beta.14...v1.31.0-beta.15) (2023-03-01)

### πŸ• Features

* default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.32.0-beta.1](open-sauced/app@v1.31.0...v1.32.0-beta.1) (2023-03-02)

### πŸ• Features

* add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853)
* add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903)
* default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929)
* implement highlights feed page ([#913](open-sauced/app#913)) ([6271c91](open-sauced/app@6271c91)), closes [#900](open-sauced/app#900) [#829](open-sauced/app#829)
* navigate to user contributions tab if there are no user highlights ([#918](open-sauced/app#918)) ([3bb20ef](open-sauced/app@3bb20ef)), closes [#914](open-sauced/app#914) [#916](open-sauced/app#916)
* update default user profile bio ([#926](open-sauced/app#926)) ([2a95817](open-sauced/app@2a95817)), closes [#922](open-sauced/app#922)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.32.0](open-sauced/app@v1.31.0...v1.32.0) (2023-03-02)

### πŸ• Features

* add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853)
* add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903)
* default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929)
* implement highlights feed page ([#913](open-sauced/app#913)) ([6271c91](open-sauced/app@6271c91)), closes [#900](open-sauced/app#900) [#829](open-sauced/app#829)
* navigate to user contributions tab if there are no user highlights ([#918](open-sauced/app#918)) ([3bb20ef](open-sauced/app@3bb20ef)), closes [#914](open-sauced/app#914) [#916](open-sauced/app#916)
* update default user profile bio ([#926](open-sauced/app#926)) ([2a95817](open-sauced/app@2a95817)), closes [#922](open-sauced/app#922)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.33.0-beta.1](open-sauced/app@v1.32.0...v1.33.0-beta.1) (2023-03-03)

### πŸ› Bug Fixes

*  broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937)

### πŸ• Features

* expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.33.0](open-sauced/app@v1.32.0...v1.33.0) (2023-03-07)

### πŸ› Bug Fixes

*  broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937)
* Add highlights placeholder ([#945](open-sauced/app#945)) ([034d550](open-sauced/app@034d550))
* check for contributor commit data before updating graph ([#941](open-sauced/app#941)) ([58a74fe](open-sauced/app@58a74fe))
* Highlights UX copy bandaid ([#944](open-sauced/app#944)) ([8a7d559](open-sauced/app@8a7d559))
* keep initial user settings data after being fetched ([#959](open-sauced/app#959)) ([b869863](open-sauced/app@b869863)), closes [#931](open-sauced/app#931)

### πŸ§‘β€πŸ’» Code Refactoring

* update non-connected user avatar  ([#967](open-sauced/app#967)) ([51bf664](open-sauced/app@51bf664)), closes [#964](open-sauced/app#964)

### πŸ• Features

* add repository search to the create insights page ([#958](open-sauced/app#958)) ([d6f151c](open-sauced/app@d6f151c)), closes [#932](open-sauced/app#932)
* add reuseable error component to the design system ([#954](open-sauced/app#954)) ([56e986b](open-sauced/app@56e986b)), closes [#781](open-sauced/app#781) [#700](open-sauced/app#700)
* expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930)
* make highlights avatar and handle clickable on feeds page ([#953](open-sauced/app#953)) ([fd59918](open-sauced/app@fd59918)), closes [#940](open-sauced/app#940) [#935](open-sauced/app#935)
* make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701)
* make user profile interest clickable ([#952](open-sauced/app#952)) ([370bc8a](open-sauced/app@370bc8a)), closes [#942](open-sauced/app#942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Default explore topic should match with the first interest selected.
4 participants