feat: make the entire insight page buttons clickable #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
approved these changes
Mar 7, 2023
brandonroberts
changed the title
OgDev-01
suggested changes
Mar 7, 2023
| @@ -73,16 +73,16 @@ const InsightRow = ({ insight, user }: InsightRowProps) => { | |||
| </div> | |||
| </div> | |||
| <div className="flex-1 hidden md:flex justify-end"> | |||
| <span className=" bg-light-slate-1 inline-block rounded-lg p-2.5 border mr-2"> | |||
| <span className=" bg-light-slate-1 inline-block rounded-lg p-2.5 border mr-2 cursor-pointer"> | |||
There was a problem hiding this comment.
This doesn’t change the click behavior, instead, it give an unclickable pointer when hovered on the span element.
A suggestion is to make the span the link instead of nesting within to achieve the title of this PR 🍕
nightknighto
approved these changes
Mar 7, 2023
|
🎉 This PR is included in version 1.33.0-beta.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
## [1.33.0](v1.32.0...v1.33.0) (2023-03-07) ### 🐛 Bug Fixes * broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937) * Add highlights placeholder ([#945](#945)) ([034d550](034d550)) * check for contributor commit data before updating graph ([#941](#941)) ([58a74fe](58a74fe)) * Highlights UX copy bandaid ([#944](#944)) ([8a7d559](8a7d559)) * keep initial user settings data after being fetched ([#959](#959)) ([b869863](b869863)), closes [#931](#931) ### 🧑💻 Code Refactoring * update non-connected user avatar ([#967](#967)) ([51bf664](51bf664)), closes [#964](#964) ### 🍕 Features * add repository search to the create insights page ([#958](#958)) ([d6f151c](d6f151c)), closes [#932](#932) * add reuseable error component to the design system ([#954](#954)) ([56e986b](56e986b)), closes [#781](#781) [#700](#700) * expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930) * make highlights avatar and handle clickable on feeds page ([#953](#953)) ([fd59918](fd59918)), closes [#940](#940) [#935](#935) * make the entire insight page buttons clickable ([#960](#960)) ([7a7708f](7a7708f)), closes [#701](#701) * make user profile interest clickable ([#952](#952)) ([370bc8a](370bc8a)), closes [#942](#942)
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.33.0-beta.9](open-sauced/app@v1.33.0-beta.8...v1.33.0-beta.9) (2023-03-07) ### 🍕 Features * make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701)
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.33.0](open-sauced/app@v1.32.0...v1.33.0) (2023-03-07) ### 🐛 Bug Fixes * broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937) * Add highlights placeholder ([#945](open-sauced/app#945)) ([034d550](open-sauced/app@034d550)) * check for contributor commit data before updating graph ([#941](open-sauced/app#941)) ([58a74fe](open-sauced/app@58a74fe)) * Highlights UX copy bandaid ([#944](open-sauced/app#944)) ([8a7d559](open-sauced/app@8a7d559)) * keep initial user settings data after being fetched ([#959](open-sauced/app#959)) ([b869863](open-sauced/app@b869863)), closes [#931](open-sauced/app#931) ### 🧑💻 Code Refactoring * update non-connected user avatar ([#967](open-sauced/app#967)) ([51bf664](open-sauced/app@51bf664)), closes [#964](open-sauced/app#964) ### 🍕 Features * add repository search to the create insights page ([#958](open-sauced/app#958)) ([d6f151c](open-sauced/app@d6f151c)), closes [#932](open-sauced/app#932) * add reuseable error component to the design system ([#954](open-sauced/app#954)) ([56e986b](open-sauced/app@56e986b)), closes [#781](open-sauced/app#781) [#700](open-sauced/app#700) * expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930) * make highlights avatar and handle clickable on feeds page ([#953](open-sauced/app#953)) ([fd59918](open-sauced/app@fd59918)), closes [#940](open-sauced/app#940) [#935](open-sauced/app#935) * make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701) * make user profile interest clickable ([#952](open-sauced/app#952)) ([370bc8a](open-sauced/app@370bc8a)), closes [#942](open-sauced/app#942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR makes the entire "next/go to insight page" button iclickable.
Related Tickets & Documents
Fixes #701
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?