Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update non connect user avatar #967

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Mar 7, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR:

  • replaces non-connected user's avatar with fallback initials.
  • Updates avatar props to include initialsClassNames for styling the initials

Related Tickets & Documents

Fixes #964

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Mar 7, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit d5b4a3d
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/640757550a87510008dbb4a7
😎 Deploy Preview https://deploy-preview-967--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 7, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit d5b4a3d
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/640757550a87510008dbb4a9
😎 Deploy Preview https://deploy-preview-967--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts added the needs review PRs that need review from core engineering team label Mar 7, 2023
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

@brandonroberts brandonroberts merged commit 51bf664 into beta Mar 7, 2023
@brandonroberts brandonroberts deleted the 964-avatar-fallback branch March 7, 2023 16:36
github-actions bot pushed a commit that referenced this pull request Mar 7, 2023
## [1.33.0-beta.8](v1.33.0-beta.7...v1.33.0-beta.8) (2023-03-07)

### πŸ§‘β€πŸ’» Code Refactoring

* update non-connected user avatar  ([#967](#967)) ([51bf664](51bf664)), closes [#964](#964)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

πŸŽ‰ This PR is included in version 1.33.0-beta.8 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Mar 7, 2023
## [1.33.0](v1.32.0...v1.33.0) (2023-03-07)

### πŸ› Bug Fixes

*  broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937)
* Add highlights placeholder ([#945](#945)) ([034d550](034d550))
* check for contributor commit data before updating graph ([#941](#941)) ([58a74fe](58a74fe))
* Highlights UX copy bandaid ([#944](#944)) ([8a7d559](8a7d559))
* keep initial user settings data after being fetched ([#959](#959)) ([b869863](b869863)), closes [#931](#931)

### πŸ§‘β€πŸ’» Code Refactoring

* update non-connected user avatar  ([#967](#967)) ([51bf664](51bf664)), closes [#964](#964)

### πŸ• Features

* add repository search to the create insights page ([#958](#958)) ([d6f151c](d6f151c)), closes [#932](#932)
* add reuseable error component to the design system ([#954](#954)) ([56e986b](56e986b)), closes [#781](#781) [#700](#700)
* expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930)
* make highlights avatar and handle clickable on feeds page ([#953](#953)) ([fd59918](fd59918)), closes [#940](#940) [#935](#935)
* make the entire insight page buttons clickable ([#960](#960)) ([7a7708f](7a7708f)), closes [#701](#701)
* make user profile interest clickable ([#952](#952)) ([370bc8a](370bc8a)), closes [#942](#942)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

πŸŽ‰ This PR is included in version 1.33.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.33.0-beta.8](open-sauced/app@v1.33.0-beta.7...v1.33.0-beta.8) (2023-03-07)

### πŸ§‘β€πŸ’» Code Refactoring

* update non-connected user avatar  ([#967](open-sauced/app#967)) ([51bf664](open-sauced/app@51bf664)), closes [#964](open-sauced/app#964)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.33.0](open-sauced/app@v1.32.0...v1.33.0) (2023-03-07)

### πŸ› Bug Fixes

*  broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937)
* Add highlights placeholder ([#945](open-sauced/app#945)) ([034d550](open-sauced/app@034d550))
* check for contributor commit data before updating graph ([#941](open-sauced/app#941)) ([58a74fe](open-sauced/app@58a74fe))
* Highlights UX copy bandaid ([#944](open-sauced/app#944)) ([8a7d559](open-sauced/app@8a7d559))
* keep initial user settings data after being fetched ([#959](open-sauced/app#959)) ([b869863](open-sauced/app@b869863)), closes [#931](open-sauced/app#931)

### πŸ§‘β€πŸ’» Code Refactoring

* update non-connected user avatar  ([#967](open-sauced/app#967)) ([51bf664](open-sauced/app@51bf664)), closes [#964](open-sauced/app#964)

### πŸ• Features

* add repository search to the create insights page ([#958](open-sauced/app#958)) ([d6f151c](open-sauced/app@d6f151c)), closes [#932](open-sauced/app#932)
* add reuseable error component to the design system ([#954](open-sauced/app#954)) ([56e986b](open-sauced/app@56e986b)), closes [#781](open-sauced/app#781) [#700](open-sauced/app#700)
* expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930)
* make highlights avatar and handle clickable on feeds page ([#953](open-sauced/app#953)) ([fd59918](open-sauced/app@fd59918)), closes [#940](open-sauced/app#940) [#935](open-sauced/app#935)
* make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701)
* make user profile interest clickable ([#952](open-sauced/app#952)) ([370bc8a](open-sauced/app@370bc8a)), closes [#942](open-sauced/app#942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team released on @beta released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Non-verified users need an avatar fallback
3 participants