Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Make the entire 'next button/go to insight page' clickable, not the inner icon only. #701

Closed
2 tasks done
shamimbinnur opened this issue Dec 21, 2022 · 5 comments · Fixed by #960
Closed
2 tasks done

Feature: Make the entire 'next button/go to insight page' clickable, not the inner icon only. #701

shamimbinnur opened this issue Dec 21, 2022 · 5 comments · Fixed by #960
Assignees
@shamimbinnur
Labels
💡 feature released on @beta released
Milestone
Papercuts

Comments

@shamimbinnur
Copy link
Contributor

Type of feature

🍕 Feature

Current behavior

At the moment the entire "next/go to insight page" button is not clickable. I have to forcefully take the mouse pointer exactly on the inner icon to click. I think is kinda inconvenient for the user experience.

Steps to reproduce the scenario:

  1. Connect with GitHub.
  2. Click "Add insight page"
  3. Fill up the form with a page and repository full name.
  4. Add repository
  5. Click "Create page".

Then you will get the "next button/go to insight page".

Screen.Recording.2022-12-21.at.5.19.02.PM.mov

Suggested solution

  1. Fill the blank space of the button with padding around the icon.
  2. Set the onClick listener on the parent element that wraps the icon.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added this to the Papercuts milestone Dec 21, 2022
@SimranjitKaurMaan
Copy link
Contributor

.take

@github-actions
Copy link
Contributor

The auto-take issues workflow is not enabled here, we can only assign issues to @open-sauced/triage, @open-sauced/committers, @open-sauced/maintainers in this repo for now. We suggest folks not on the team open issues and take a look at the Bugs or Papercuts. If you would like to find good first issues, please check out the companion project to this, open-sauced/hot.

@bdougie
Copy link
Member

bdougie commented Feb 9, 2023

Checking in on this @SimranjitKaurMaan. Let me know if you have bandwidth for this.

@shamimbinnur shamimbinnur mentioned this issue Mar 6, 2023
Merged
19 tasks
@shamimbinnur shamimbinnur moved this from Todo to In Progress in OpenSauced Operational Roadmap Mar 6, 2023
brandonroberts pushed a commit that referenced this issue Mar 7, 2023
@shamimbinnur
feat: make the entire insight page buttons clickable (#960)
7a7708f 
Fixes #701
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenSauced Operational Roadmap Mar 7, 2023
github-actions bot pushed a commit that referenced this issue Mar 7, 2023
@shamimbinnur @open-sauced
chore(minor): release 1.33.0-beta.9 on beta channel [skip ci]
bbc9334 
## [1.33.0-beta.9](v1.33.0-beta.8...v1.33.0-beta.9) (2023-03-07)

### 🍕 Features

* make the entire insight page buttons clickable ([#960](#960)) ([7a7708f](7a7708f)), closes [#701](#701)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

🎉 This issue has been resolved in version 1.33.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 7, 2023
@brandonroberts @open-sauced
chore(minor): release 1.33.0 [skip ci]
810e0f6 
## [1.33.0](v1.32.0...v1.33.0) (2023-03-07)

### 🐛 Bug Fixes

*  broken css on button component ([#938](#938)) ([6ba2365](6ba2365)), closes [#934](#934) [#937](#937)
* Add highlights placeholder ([#945](#945)) ([034d550](034d550))
* check for contributor commit data before updating graph ([#941](#941)) ([58a74fe](58a74fe))
* Highlights UX copy bandaid ([#944](#944)) ([8a7d559](8a7d559))
* keep initial user settings data after being fetched ([#959](#959)) ([b869863](b869863)), closes [#931](#931)

### 🧑‍💻 Code Refactoring

* update non-connected user avatar  ([#967](#967)) ([51bf664](51bf664)), closes [#964](#964)

### 🍕 Features

* add repository search to the create insights page ([#958](#958)) ([d6f151c](d6f151c)), closes [#932](#932)
* add reuseable error component to the design system ([#954](#954)) ([56e986b](56e986b)), closes [#781](#781) [#700](#700)
* expand list of topics and interests ([#939](#939)) ([a607062](a607062)), closes [#927](#927) [#930](#930)
* make highlights avatar and handle clickable on feeds page ([#953](#953)) ([fd59918](fd59918)), closes [#940](#940) [#935](#935)
* make the entire insight page buttons clickable ([#960](#960)) ([7a7708f](7a7708f)), closes [#701](#701)
* make user profile interest clickable ([#952](#952)) ([370bc8a](370bc8a)), closes [#942](#942)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

🎉 This issue has been resolved in version 1.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.33.0-beta.9 on beta channel [skip ci]
678fa39 
## [1.33.0-beta.9](open-sauced/app@v1.33.0-beta.8...v1.33.0-beta.9) (2023-03-07)

### 🍕 Features

* make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.33.0 [skip ci]
7ca0ad5 
## [1.33.0](open-sauced/app@v1.32.0...v1.33.0) (2023-03-07)

### 🐛 Bug Fixes

*  broken css on button component ([#938](open-sauced/app#938)) ([6ba2365](open-sauced/app@6ba2365)), closes [#934](open-sauced/app#934) [#937](open-sauced/app#937)
* Add highlights placeholder ([#945](open-sauced/app#945)) ([034d550](open-sauced/app@034d550))
* check for contributor commit data before updating graph ([#941](open-sauced/app#941)) ([58a74fe](open-sauced/app@58a74fe))
* Highlights UX copy bandaid ([#944](open-sauced/app#944)) ([8a7d559](open-sauced/app@8a7d559))
* keep initial user settings data after being fetched ([#959](open-sauced/app#959)) ([b869863](open-sauced/app@b869863)), closes [#931](open-sauced/app#931)

### 🧑‍💻 Code Refactoring

* update non-connected user avatar  ([#967](open-sauced/app#967)) ([51bf664](open-sauced/app@51bf664)), closes [#964](open-sauced/app#964)

### 🍕 Features

* add repository search to the create insights page ([#958](open-sauced/app#958)) ([d6f151c](open-sauced/app@d6f151c)), closes [#932](open-sauced/app#932)
* add reuseable error component to the design system ([#954](open-sauced/app#954)) ([56e986b](open-sauced/app@56e986b)), closes [#781](open-sauced/app#781) [#700](open-sauced/app#700)
* expand list of topics and interests ([#939](open-sauced/app#939)) ([a607062](open-sauced/app@a607062)), closes [#927](open-sauced/app#927) [#930](open-sauced/app#930)
* make highlights avatar and handle clickable on feeds page ([#953](open-sauced/app#953)) ([fd59918](open-sauced/app@fd59918)), closes [#940](open-sauced/app#940) [#935](open-sauced/app#935)
* make the entire insight page buttons clickable ([#960](open-sauced/app#960)) ([7a7708f](open-sauced/app@7a7708f)), closes [#701](open-sauced/app#701)
* make user profile interest clickable ([#952](open-sauced/app#952)) ([370bc8a](open-sauced/app@370bc8a)), closes [#942](open-sauced/app#942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shamimbinnur shamimbinnur

Labels
💡 feature released on @beta released
Projects
No open projects
OpenSauced Operational Roadmap
Status: Done
Milestone
Papercuts
Development

Successfully merging a pull request may close this issue.

feat: make the entire insight page buttons clickable shamimbinnur/app
3 participants
@bdougie @SimranjitKaurMaan @shamimbinnur