feat: delete insight page #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
requested changes
Feb 28, 2023
bdougie
requested changes
Feb 28, 2023
There was a problem hiding this comment.
It works, but I agree with @OgDev-01 that we should visible disable the button if "DELETE" is not present. Current the button doesn't work, but we should show the 🚫 on the button
bdougie
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Thanks @shamimbinnur. Would love to see this PR as a Highlight
brandonroberts
approved these changes
Mar 1, 2023
@bdougie I just did it! |
OgDev-01
approved these changes
Mar 1, 2023
|
🎉 This PR is included in version 1.31.0-beta.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
## [1.32.0-beta.1](v1.31.0...v1.32.0-beta.1) (2023-03-02) ### 🍕 Features * add ability to delete an insight page ([#920](#920)) ([e1cd798](e1cd798)), closes [#853](#853) * add loading state to highlight cards ([#921](#921)) ([63c2cc1](63c2cc1)), closes [#903](#903) * default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929) * implement highlights feed page ([#913](#913)) ([6271c91](6271c91)), closes [#900](#900) [#829](#829) * navigate to user contributions tab if there are no user highlights ([#918](#918)) ([3bb20ef](3bb20ef)), closes [#914](#914) [#916](#916) * update default user profile bio ([#926](#926)) ([2a95817](2a95817)), closes [#922](#922)
|
🎉 This PR is included in version 1.32.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
## [1.32.0](v1.31.0...v1.32.0) (2023-03-02) ### 🍕 Features * add ability to delete an insight page ([#920](#920)) ([e1cd798](e1cd798)), closes [#853](#853) * add loading state to highlight cards ([#921](#921)) ([63c2cc1](63c2cc1)), closes [#903](#903) * default explore topic matches user interest ([#930](#930)) ([e73c9dd](e73c9dd)), closes [#929](#929) * implement highlights feed page ([#913](#913)) ([6271c91](6271c91)), closes [#900](#900) [#829](#829) * navigate to user contributions tab if there are no user highlights ([#918](#918)) ([3bb20ef](3bb20ef)), closes [#914](#914) [#916](#916) * update default user profile bio ([#926](#926)) ([2a95817](2a95817)), closes [#922](#922)
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.31.0-beta.12](open-sauced/app@v1.31.0-beta.11...v1.31.0-beta.12) (2023-03-01) ### 🍕 Features * add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853) * add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903)
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.32.0-beta.1](open-sauced/app@v1.31.0...v1.32.0-beta.1) (2023-03-02) ### 🍕 Features * add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853) * add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903) * default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929) * implement highlights feed page ([#913](open-sauced/app#913)) ([6271c91](open-sauced/app@6271c91)), closes [#900](open-sauced/app#900) [#829](open-sauced/app#829) * navigate to user contributions tab if there are no user highlights ([#918](open-sauced/app#918)) ([3bb20ef](open-sauced/app@3bb20ef)), closes [#914](open-sauced/app#914) [#916](open-sauced/app#916) * update default user profile bio ([#926](open-sauced/app#926)) ([2a95817](open-sauced/app@2a95817)), closes [#922](open-sauced/app#922)
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.32.0](open-sauced/app@v1.31.0...v1.32.0) (2023-03-02) ### 🍕 Features * add ability to delete an insight page ([#920](open-sauced/app#920)) ([e1cd798](open-sauced/app@e1cd798)), closes [#853](open-sauced/app#853) * add loading state to highlight cards ([#921](open-sauced/app#921)) ([63c2cc1](open-sauced/app@63c2cc1)), closes [#903](open-sauced/app#903) * default explore topic matches user interest ([#930](open-sauced/app#930)) ([e73c9dd](open-sauced/app@e73c9dd)), closes [#929](open-sauced/app#929) * implement highlights feed page ([#913](open-sauced/app#913)) ([6271c91](open-sauced/app@6271c91)), closes [#900](open-sauced/app#900) [#829](open-sauced/app#829) * navigate to user contributions tab if there are no user highlights ([#918](open-sauced/app#918)) ([3bb20ef](open-sauced/app@3bb20ef)), closes [#914](open-sauced/app#914) [#916](open-sauced/app#916) * update default user profile bio ([#926](open-sauced/app#926)) ([2a95817](open-sauced/app@2a95817)), closes [#922](open-sauced/app#922)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds the ability to delete the insight page. Once the user clicks on the button "delete page" a confirmation modal will appear and ask the user to write
DELETEin order to confirm the deletion.Related Tickets & Documents
Fixes #853
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?