Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language update - change developer to contributor #1274

Conversation

babblebey
Copy link
Contributor

@babblebey babblebey commented Jun 18, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR aims to address issue #1247 by updating the term "developer" to "contributor". Currently, some of the parts of the project as seen here - https://github.com/search?q=repo%3Aopen-sauced%2Finsights%20developer&type=code refers to contributor as developer, which isn't inclusive of non-developers.

This PR standardizes our language and uses "contributor" rather than developer.

Related Tickets & Documents

#1247

Mobile & Desktop Screenshots/Recordings

NA

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

NA

[optional] What gif best describes this PR or how it makes you feel?

😁

fixes #1247

@netlify
Copy link

netlify bot commented Jun 18, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 2d1ade2
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6490835cc5a3230008d4443d
😎 Deploy Preview https://deploy-preview-1274--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 18, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 2d1ade2
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6490835cb0c8f0000872ef19
😎 Deploy Preview https://deploy-preview-1274--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❀️! πŸŽ‰πŸ•
Say hello by joining the conversation in our Discord

@a0m0rajab
Copy link
Contributor

Congratulation on your first PRπŸŽ‰
@babblebey just one single thing that you might do is to add this Fixes #1274 in your PR description.
This will help with auto-close the related issue and connect them together.
If you want to understand how it works you might take a look at this doc.

Other than that it looks good for me.

@babblebey
Copy link
Contributor Author

Done @a0m0rajab

Kindly confirm if I have done this correctly.

Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ• πŸ•

@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Jun 19, 2023
@brandonroberts brandonroberts requested a review from BekahHW June 20, 2023 01:08
@brandonroberts brandonroberts added ready-to-merge and removed needs review PRs that need review from core engineering team labels Jun 20, 2023
@brandonroberts brandonroberts merged commit 7e86ac9 into open-sauced:beta Jun 20, 2023
github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
## [1.53.0-beta.2](v1.53.0-beta.1...v1.53.0-beta.2) (2023-06-20)

### πŸ› Bug Fixes

* language update - change developer to contributor ([#1274](#1274)) ([7e86ac9](7e86ac9)), closes [#1247](#1247)
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.53.0-beta.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 22, 2023
## [1.53.0](v1.52.0...v1.53.0) (2023-06-22)

### πŸ• Features

* handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7))

### πŸ› Bug Fixes

* language update - change developer to contributor ([#1274](#1274)) ([7e86ac9](7e86ac9)), closes [#1247](#1247)
* link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16))
* properly format local time displayed on user's profile ([#1282](#1282)) ([604cc62](604cc62))
* remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3))
* scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.53.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@babblebey babblebey deleted the fix--language-update---change-developer-to-contributor branch July 31, 2023 15:06
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.53.0-beta.2](open-sauced/app@v1.53.0-beta.1...v1.53.0-beta.2) (2023-06-20)

### πŸ› Bug Fixes

* language update - change developer to contributor ([#1274](open-sauced/app#1274)) ([7e86ac9](open-sauced/app@7e86ac9)), closes [#1247](open-sauced/app#1247)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.53.0](open-sauced/app@v1.52.0...v1.53.0) (2023-06-22)

### πŸ• Features

* handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7))

### πŸ› Bug Fixes

* language update - change developer to contributor ([#1274](open-sauced/app#1274)) ([7e86ac9](open-sauced/app@7e86ac9)), closes [#1247](open-sauced/app#1247)
* link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16))
* properly format local time displayed on user's profile ([#1282](open-sauced/app#1282)) ([604cc62](open-sauced/app@604cc62))
* remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3))
* scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language update: change developer to contributor
5 participants