feat: add top contributors panel to feeds page #1347

OgDev-01 · 2023-07-12T13:36:06Z

Description

This pull request adds a top user's panel to the application. The panel displays dummy data for now, but it will be updated with real user information once https://github.com/open-sauced/api/pull/200 is merged. This feature enhances the user experience by showcasing the most active users.

Generated using OpenSauced.

What type of PR is this? (check all applicable)

Related Tickets & Documents

closes #598

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-07-12T13:36:11Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`e9905c3`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/64b550d39b8a810008fab369
😎 Deploy Preview	https://deploy-preview-1347--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-07-12T13:36:11Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`e9905c3`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/64b550d34bd77f00087ed7ac
😎 Deploy Preview	https://deploy-preview-1347--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NsdHSO

IHMO nice feature, but If the user press the follow button, he can't unfollow

components/molecules/TopUsersPanel/top-user-panel.tsx

bdougie

My suggestion is changing s/Users/Contributors/g for reason laid out inline.

This also aligns with the work @babblebey did here #1274

jpmcb

The follow / unfollow flow looks to be working 👍🏼

components/atoms/TopUserCard/top-user-card.tsx

OgDev-01 · 2023-07-13T07:51:28Z

My suggestion is changing s/Users/Contributors/g for reason laid out inline.

Can you elaborate more on this? I still don't understand changing s/Users/Contributors/g

components/atoms/TopUserCard/top-user-card.tsx

bdougie · 2023-07-13T13:35:56Z

Can you elaborate more on this? I still don't understand changing s/Users/Contributors/g

Instead of "Top Users" make it "Top Contributors"

All your variables use the word users. I provided the short Unix command for finding and replacing in a file. https://www.cyberciti.biz/faq/how-to-use-sed-to-find-and-replace-text-in-files-in-linux-unix-shell/

Ignore that, just do it manually.

…mplement-top-users

BekahHW · 2023-07-17T00:59:24Z

Totally missed the conversation. Contributors is definitely a more inviting terminology. Both in what the users see and the code that users are interacting with.

Using “contributor” instead of “user” emphasizes active participation and engagement of community members. Here are a couple more reasons to use this terminology:

1.	Encourages active involvement: By using “contributor,” we highlight the importance of active participation rather than passive consumption, encouraging individuals to contribute skills, knowledge, and ideas to improve the project.
2.	Fosters a sense of ownership: Referring to contributors recognizes valuable contributions and ownership and investment in the project, reinforcing the idea that the project’s success is built upon the collective efforts of its contributors.
3.	Reflects a collaborative mindset: Using “contributor” signifies that the project is a collective effort, and everyone’s contributions are valued, regardless of the scale or nature of their involvement.
4.	Encourages diverse contributions: Using the term “contributor” rather than “user” encourages a broader range of diverse skillsets and backgrounds--not just coding.

OgDev-01 · 2023-07-17T13:31:33Z

Update: All naming copies has been updated 🍕

components/atoms/TopContributorCard/top-contributor-card.tsx

components/molecules/TopContributorsPanel/top-contributors-panel.tsx

lib/hooks/useFetchTopUsers.ts

lib/hooks/useFollowUser.ts

jpmcb

LGTM!

## [1.56.0-beta.12](v1.56.0-beta.11...v1.56.0-beta.12) (2023-07-17) ### 🍕 Features * add top contributors panel to feeds page ([#1347](#1347)) ([5b58dd5](5b58dd5))

github-actions · 2023-07-17T14:58:38Z

🎉 This PR is included in version 1.56.0-beta.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.56.0](v1.55.0...v1.56.0) (2023-07-17) ### 🐛 Bug Fixes * add hidden form for Netlify forms submission ([#1351](#1351)) ([8075012](8075012)) * ensure font color of selected interests pill changed is white ([#1342](#1342)) ([b778f11](b778f11)) * improve loading performance of individual highlight ([#1349](#1349)) ([9e193fe](9e193fe)) * prevent concurrent user profile update requests ([#1372](#1372)) ([b23b9df](b23b9df)) ### 🎨 Styles * text inputs colors were not consistent in the user settings page ([#1360](#1360)) ([edae9c4](edae9c4)) ### 🍕 Features * add force login component to design system ([#1330](#1330)) ([9d68ffc](9d68ffc)) * add top contributors panel to feeds page ([#1347](#1347)) ([5b58dd5](5b58dd5)) * added new topics to the list ([#1357](#1357)) ([33f03bb](33f03bb)) * change position of visibility action component ([#1331](#1331)) ([f3f615c](f3f615c)) * changed the last commit date icon with a calender ([#1350](#1350)) ([2ae9d53](2ae9d53)) * implement featured highlights list ([#1337](#1337)) ([ed32594](ed32594)) * implement newsletter submission functionality ([#1332](#1332)) ([d996ac7](d996ac7)) * upgrade to Next 13.4, Supabase helper libs to 0.7.x ([#1301](#1301)) ([26876c2](26876c2))

github-actions · 2023-07-17T16:19:57Z

🎉 This PR is included in version 1.56.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat: add top users panel with dummy data

7fc49b3

OgDev-01 marked this pull request as draft July 12, 2023 13:36

OgDev-01 changed the title ~~feat: add top users panel with dummy data~~ feat: add top users panel to feeds page Jul 12, 2023

OgDev-01 added 3 commits July 12, 2023 14:44

fix: build error

4ed1016

feat: add live data and optimize ui

8a0dd01

fix: build error

141e529

OgDev-01 marked this pull request as ready for review July 12, 2023 16:51

OgDev-01 requested review from brandonroberts and bdougie July 12, 2023 16:55

NsdHSO reviewed Jul 12, 2023

View reviewed changes

OgDev-01 added the needs review PRs that need review from core engineering team label Jul 12, 2023

fix: unfollow issue

5c3965d

bdougie reviewed Jul 12, 2023

View reviewed changes

components/molecules/TopUsersPanel/top-user-panel.tsx Outdated Show resolved Hide resolved

bdougie requested changes Jul 12, 2023

View reviewed changes

jpmcb reviewed Jul 12, 2023

View reviewed changes

NsdHSO reviewed Jul 13, 2023

View reviewed changes

components/atoms/TopUserCard/top-user-card.tsx Outdated Show resolved Hide resolved

OgDev-01 added 2 commits July 13, 2023 08:48

chore: refresh users stats on follow action trigger

c539e97

misc: remove console log

5a09b62

NsdHSO reviewed Jul 13, 2023

View reviewed changes

components/atoms/TopUserCard/top-user-card.tsx Outdated Show resolved Hide resolved

bdougie mentioned this pull request Jul 14, 2023

feature: top contributors feature #598

Closed

brandonroberts added requested changes and removed needs review PRs that need review from core engineering team labels Jul 14, 2023

OgDev-01 changed the title ~~feat: add top users panel to feeds page~~ feat: add top contributors panel to feeds page Jul 16, 2023

OgDev-01 added 2 commits July 16, 2023 22:53

chore: add global mutation and update general naming

fa42e4c

Merge branch 'beta' of https://github.com/open-sauced/insights into i…

954c03c

…mplement-top-users

OgDev-01 requested a review from bdougie July 16, 2023 22:01

OgDev-01 requested a review from NsdHSO July 16, 2023 22:01

OgDev-01 added needs review PRs that need review from core engineering team and removed requested changes labels Jul 16, 2023

brandonroberts requested changes Jul 17, 2023

View reviewed changes

brandonroberts added requested changes and removed needs review PRs that need review from core engineering team labels Jul 17, 2023

OgDev-01 added 2 commits July 17, 2023 15:30

chore: review changes

2e46a6f

misc: copy update

e9905c3

OgDev-01 requested a review from brandonroberts July 17, 2023 14:33

brandonroberts approved these changes Jul 17, 2023

View reviewed changes

jpmcb approved these changes Jul 17, 2023

View reviewed changes

brandonroberts added ready-to-merge and removed requested changes labels Jul 17, 2023

OgDev-01 merged commit 5b58dd5 into beta Jul 17, 2023

OgDev-01 deleted the implement-top-users branch July 17, 2023 14:51

github-actions bot added the released on @beta label Jul 17, 2023

github-actions bot added the released label Jul 17, 2023

bdougie mentioned this pull request Jul 18, 2023

feat: 404 page #1390

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add top contributors panel to feeds page #1347

feat: add top contributors panel to feeds page #1347

OgDev-01 commented Jul 12, 2023 •

edited by bdougie

Loading

netlify bot commented Jul 12, 2023 •

edited

Loading

netlify bot commented Jul 12, 2023 •

edited

Loading

NsdHSO left a comment •

edited

Loading

bdougie left a comment

jpmcb left a comment •

edited

Loading

OgDev-01 commented Jul 13, 2023

bdougie commented Jul 13, 2023

BekahHW commented Jul 17, 2023

OgDev-01 commented Jul 17, 2023

jpmcb left a comment

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

feat: add top contributors panel to feeds page #1347

feat: add top contributors panel to feeds page #1347

Conversation

OgDev-01 commented Jul 12, 2023 • edited by bdougie Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Jul 12, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Jul 12, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

NsdHSO left a comment • edited Loading

Choose a reason for hiding this comment

bdougie left a comment

Choose a reason for hiding this comment

jpmcb left a comment • edited Loading

Choose a reason for hiding this comment

OgDev-01 commented Jul 13, 2023

bdougie commented Jul 13, 2023

BekahHW commented Jul 17, 2023

OgDev-01 commented Jul 17, 2023

jpmcb left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 17, 2023

github-actions bot commented Jul 17, 2023

OgDev-01 commented Jul 12, 2023 •

edited by bdougie

Loading

netlify bot commented Jul 12, 2023 •

edited

Loading

netlify bot commented Jul 12, 2023 •

edited

Loading

NsdHSO left a comment •

edited

Loading

jpmcb left a comment •

edited

Loading