fix: improve loading performance of individual highlight #1349
Conversation
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
brandonroberts
changed the title
This reverts commit 7d0fd7f.
|
I had trouble QAing this. created a video Rewatch.Screen.Recording.-.2023-07-12.at.2.37.06.PM.mp4 |
|
Interesting. This happens on current |
There was a problem hiding this comment.
Not sure if this is related, but the follow button's style doesn't look quite right to me on the beta deployment:
(notice how the follow button looks too wide and spills over to the left compared to the rest of the column)
On the live hightlights page, the alignment looks correct:
## [1.56.0-beta.9](v1.56.0-beta.8...v1.56.0-beta.9) (2023-07-14) ### 🐛 Bug Fixes * improve loading performance of individual highlight ([#1349](#1349)) ([9e193fe](9e193fe))
|
🎉 This PR is included in version 1.56.0-beta.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.56.0](v1.55.0...v1.56.0) (2023-07-17) ### 🐛 Bug Fixes * add hidden form for Netlify forms submission ([#1351](#1351)) ([8075012](8075012)) * ensure font color of selected interests pill changed is white ([#1342](#1342)) ([b778f11](b778f11)) * improve loading performance of individual highlight ([#1349](#1349)) ([9e193fe](9e193fe)) * prevent concurrent user profile update requests ([#1372](#1372)) ([b23b9df](b23b9df)) ### 🎨 Styles * text inputs colors were not consistent in the user settings page ([#1360](#1360)) ([edae9c4](edae9c4)) ### 🍕 Features * add force login component to design system ([#1330](#1330)) ([9d68ffc](9d68ffc)) * add top contributors panel to feeds page ([#1347](#1347)) ([5b58dd5](5b58dd5)) * added new topics to the list ([#1357](#1357)) ([33f03bb](33f03bb)) * change position of visibility action component ([#1331](#1331)) ([f3f615c](f3f615c)) * changed the last commit date icon with a calender ([#1350](#1350)) ([2ae9d53](2ae9d53)) * implement featured highlights list ([#1337](#1337)) ([ed32594](ed32594)) * implement newsletter submission functionality ([#1332](#1332)) ([d996ac7](d996ac7)) * upgrade to Next 13.4, Supabase helper libs to 0.7.x ([#1301](#1301)) ([26876c2](26876c2))
|
🎉 This PR is included in version 1.56.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?