-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 404 page #1390
feat: 404 page #1390
Conversation
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fcda9c7
to
180f4d9
Compare
d3f988d
to
2aaa1b2
Compare
@foxyblocks This looks great. One ask is the card page allows key navigation and enhances the accessibility. Are we able to key bindings for navigating different cards to this PR. |
It currently supports the "left" arrow key for navigation to coincide with the arrow button. Did you want another key?? |
Oh. I was going up and down. Lol Perhaps we can include "down" and have it do the same as "left." Not sure if that is help for accessibility but would be for me. |
@foxyblocks the last build failed with some prettier changes, will you take a look? |
Signed-off-by: Aryan Singh <ssaryans597@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good. Just needs to build/lint fix.
## [1.57.0-beta.6](v1.57.0-beta.5...v1.57.0-beta.6) (2023-07-24) ### 🍕 Features * add 404 page ([#1390](#1390)) ([37bd475](37bd475))
🎉 This PR is included in version 1.57.0-beta.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2)) ### 🐛 Bug Fixes * add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46)) * Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d)) * flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14)) * Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4)) * Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7)) * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🍕 Features * add `[#100](https://github.com/open-sauced/insights/issues/100)DayOfOSS` challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf)) * add 404 page ([#1390](#1390)) ([37bd475](37bd475)) * add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b)) * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) * implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Description
Adds a new custom 404 page that shows dev cards from various users.
TODO
users/top
api endpoint to support more than 10 users, cc @OgDev-01 @brandonroberts is there a ticket for this?What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #910
Mobile & Desktop Screenshots/Recordings
CleanShot.2023-07-19.at.15.47.14.mp4
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?