Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 404 page #1390

Merged
merged 7 commits into from
Jul 24, 2023
Merged

feat: 404 page #1390

merged 7 commits into from
Jul 24, 2023

Conversation

foxyblocks
Copy link
Contributor

@foxyblocks foxyblocks commented Jul 18, 2023

Description

Adds a new custom 404 page that shows dev cards from various users.

TODO

  • Needs the users/top api endpoint to support more than 10 users, cc @OgDev-01 @brandonroberts is there a ticket for this?

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #910

Mobile & Desktop Screenshots/Recordings

CleanShot.2023-07-19.at.15.47.14.mp4
CleanShot 2023-07-19 at 15 51 11@2x

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

confused-superbowl-gif-by-republic-records

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 0b5f691
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64be70c9364c750008cbf80c
😎 Deploy Preview https://deploy-preview-1390--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 0b5f691
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64be70c904dc8300083a811b
😎 Deploy Preview https://deploy-preview-1390--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@foxyblocks foxyblocks changed the title 404 page feat: 404 page Jul 18, 2023
pages/404.tsx Outdated Show resolved Hide resolved
@foxyblocks foxyblocks force-pushed the 404-page branch 2 times, most recently from fcda9c7 to 180f4d9 Compare July 19, 2023 22:51
@foxyblocks foxyblocks marked this pull request as ready for review July 19, 2023 22:53
@foxyblocks foxyblocks force-pushed the 404-page branch 2 times, most recently from d3f988d to 2aaa1b2 Compare July 19, 2023 23:04
@bdougie
Copy link
Member

bdougie commented Jul 20, 2023

@foxyblocks This looks great. One ask is the card page allows key navigation and enhances the accessibility. Are we able to key bindings for navigating different cards to this PR.

@foxyblocks
Copy link
Contributor Author

@foxyblocks This looks great. One ask is the card page allows key navigation and enhances the accessibility. Are we able to key bindings for navigating different cards to this PR.

It currently supports the "left" arrow key for navigation to coincide with the arrow button. Did you want another key??

@bdougie
Copy link
Member

bdougie commented Jul 20, 2023

It currently supports the "left" arrow key for navigation to coincide with the arrow button. Did you want another key??

Oh. I was going up and down. Lol

Perhaps we can include "down" and have it do the same as "left." Not sure if that is help for accessibility but would be for me.

@brandonroberts
Copy link
Contributor

@foxyblocks the last build failed with some prettier changes, will you take a look?

aryanas159 and others added 2 commits July 21, 2023 09:29
Signed-off-by: Aryan Singh <ssaryans597@gmail.com>
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. Just needs to build/lint fix.

@brandonroberts brandonroberts merged commit 37bd475 into beta Jul 24, 2023
@brandonroberts brandonroberts deleted the 404-page branch July 24, 2023 13:57
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
## [1.57.0-beta.6](v1.57.0-beta.5...v1.57.0-beta.6) (2023-07-24)

### 🍕 Features

* add 404 page ([#1390](#1390)) ([37bd475](37bd475))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.57.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24)

### 🤖 Build System

* update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276))

### 🔁 Continuous Integration

* disable husky for release ([2537649](2537649))
* fix husky command during release ([3e493a2](3e493a2))

### 🐛 Bug Fixes

* add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46))
* Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d))
* flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14))
* Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4))
* Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7))
* Move card image api route ([#1401](#1401)) ([d650161](d650161))
* update top contributors response data ([#1397](#1397)) ([9053091](9053091))

### 🍕 Features

* add `[#100](https://github.com/open-sauced/insights/issues/100)DayOfOSS` challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf))
* add 404 page ([#1390](#1390)) ([37bd475](37bd475))
* add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b))
* Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80))
* add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4))
* implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576))
* implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Insights need custom 404 Not-found page
5 participants