-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement improved highlights form with ai auto-summarise #1381
Conversation
…mproved-highlight-form
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…mproved-highlight-form
@OgDev-01 nice! Can we provide some feedback that the API request is in flight? Do we prevent them from clicking the suggestion button again while its happening? |
Opps!, totally missed that. updating shortly... Thanks! |
Update: I changed the |
Some feedback:
example prompt from - open-sauced/ai#220suggestion1 & 2 should be addressed in this PR. 3 can just be using the PR title for now. We can do a follow up PR for title generation, unless you think it is approachable. |
@open-sauced/triage could use some extra eyes on this. |
…mproved-highlight-form
Pulse looks great. re: 500 words, I was testing this PR open-sauced/ai#220. But it seems fine now with the "formal" tone change. system promptrelated to this issue on system prompts - https://github.com/open-sauced/api/issues/203 A system prompt is "return any GitHub issues numbers as markdown links." That addition to the prompt would make the generated summary include links instead of plain text issues numbers. https://deploy-preview-1381--oss-insights.netlify.app/feed/154 Note: The link would need the markdown rendering from #1376 |
FYI, with the newly merged change from #1396, running |
@bdougie what are your thoughts? |
@OgDev-01 why so many files changed? |
Those changed files shouldn't be in your PR if you've merged in from beta though |
…mproved-highlight-form
…ced/insights into improved-highlight-form
…ced/insights into improved-highlight-form
This has been updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works. Extra files changed are from formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [1.57.0-beta.3](v1.57.0-beta.2...v1.57.0-beta.3) (2023-07-23) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🍕 Features * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) ### 🐛 Bug Fixes * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2))
🎉 This PR is included in version 1.57.0-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2)) ### 🐛 Bug Fixes * add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46)) * Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d)) * flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14)) * Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4)) * Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7)) * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🍕 Features * add `[#100](https://github.com/open-sauced/insights/issues/100)DayOfOSS` challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf)) * add 404 page ([#1390](#1390)) ([37bd475](37bd475)) * add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b)) * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) * implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Description
This PR:
Notes on summary generation
After testing the various
tone
available, I chooseinformative
as it seems to generate a more in-depth context of what was done in the PR in fewer words.formal
on the other hand was also nice, but it kind of generates almost same words as what was in the commit messages in the PR. I'm open to hearing thoughts on this 🍕 .The generate summary icon is disabled by default and when a request is being made to get the summary from the API to prevent users from clicking when a request is in flight.
Available tones
"exciting" | "persuasive" | "informative" | "humorous" | "formal"
What type of PR is this? (check all applicable)
Related Tickets & Documents
related #1289
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2023-07-18.at.14.11.19.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?