fix: Improved the user experience of the highlights input form #1362
Conversation
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I also ran into this today and suggested maybe a more explicit "Close" button: #1363 But it'd be worth getting some insight from @isabensusan or @bdougie on what approach we want to take with this specific UI / UX |
|
needs a |
|
I think a close button would help a lot here, but can be scoped in a separate PR. This PR handles the weirdness where the input is closed when you select the title, which is not ideal UX. There some other new UI changes coming, which will either blocked this PR or require it to merge in the next 24hrs so it is not blocking. If the build is fixed prior, then we can move forward, if not, we might need to wait until #1381 so it can be rebased here. Overall this is an improvement we should move forward with after the |
This PR updates the behaviour of the Title field so that it conditionally hides the Description field only when the Description field has zero content.
deepakrudrapaul
force-pushed
the
fix-highlight-input-form
branch
from
87f3eb5 to
af252f5
Compare
|
Thank you for your suggestion. I have run "npm run format" and pushed the changes in a single commit, we are ready to move forward. |
### [1.56.1-beta.2](v1.56.1-beta.1...v1.56.1-beta.2) (2023-07-18) ### 🐛 Bug Fixes * Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4))
|
🎉 This PR is included in version 1.56.1-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2)) ### 🐛 Bug Fixes * add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46)) * Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d)) * flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14)) * Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4)) * Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7)) * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🍕 Features * add `[#100](https://github.com/open-sauced/insights/issues/100)DayOfOSS` challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf)) * add 404 page ([#1390](#1390)) ([37bd475](37bd475)) * add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b)) * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) * implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Description
This PR updates the behaviour of the Title field so that it conditionally hides the Description field only when the Description field has zero content.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1354
Mobile & Desktop Screenshots/Recordings
Before :
Screencast from 15-07-23 03:08:39 PM IST.webm
After :
Screencast from 15-07-23 03:09:35 PM IST.webm
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
😃