build: Eslint prettier conflict #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
approved these changes
Jul 20, 2023
19 tasks
This was referenced Jul 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2023
## [1.57.0-beta.3](v1.57.0-beta.2...v1.57.0-beta.3) (2023-07-23) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🍕 Features * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) ### 🐛 Bug Fixes * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2))
|
🎉 This PR is included in version 1.57.0-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
## [1.57.0](v1.56.0...v1.57.0) (2023-07-24) ### 🤖 Build System * update eslint prettier config and setup commit hooks ([#1396](#1396)) ([ac9b276](ac9b276)) ### 🔁 Continuous Integration * disable husky for release ([2537649](2537649)) * fix husky command during release ([3e493a2](3e493a2)) ### 🐛 Bug Fixes * add `pullrequestLink` check into `HighlightInput` form `isDivFocused` condition ([#1406](#1406)) ([f3fda46](f3fda46)) * Auto-Scroll Not Triggered Upon Clicking 'Next Page' in Highlight… ([#1387](#1387)) ([77b161d](77b161d)) * flash of "test content" while loading in dashboard page ([#1409](#1409)) ([ad23f14](ad23f14)) * Improved the user experience of the highlights input form ([#1362](#1362)) ([2425dc4](2425dc4)) * Issue [#1374](#1374) All suggestions are being displayed with scroll area ([#1380](#1380)) ([1de56c7](1de56c7)) * Move card image api route ([#1401](#1401)) ([d650161](d650161)) * update top contributors response data ([#1397](#1397)) ([9053091](9053091)) ### 🍕 Features * add `[#100](https://github.com/open-sauced/insights/issues/100)DayOfOSS` challenge anouncement to feeds ([#1389](#1389)) ([751dbbf](751dbbf)) * add 404 page ([#1390](#1390)) ([37bd475](37bd475)) * add discord link to user profile ([#1370](#1370)) ([f94bc3b](f94bc3b)) * Add links to getting started docs ([#1395](#1395)) ([c58cc80](c58cc80)) * add upgrade access button to user settings page ([#1398](#1398)) ([671ebf4](671ebf4)) * implement improved highlights form with ai auto-summarise ([#1381](#1381)) ([023f576](023f576)) * implemented hover and highlight contribution graph ([#1404](#1404)) ([0453370](0453370))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed an issue with eslint having conflicts with the vscode prettier plugin with regards to how ternary statements are indented. An example of this problem can be seen when saving the
components/atoms/Pill/pill.tsxcomponent.In order to resolve this I propose letting prettier handle all formatting. This is accomplished by using the
eslint-plugin-prettierplugin. Now all prettier formatting violations will cause an eslint error and they will be auto-fixable by either prettier or theeslint --fixcommands.For those that aren't running a vscode plugin, i've also setup husky to run a pre-commit hook on any staged files to auto fix eslint issues.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?