feat: handle close highlight dialog #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
takanome-dev
commented
Jun 14, 2023
|
Not related but it seems like the Screencast.from.06-14-2023.06.51.37.PM.webm |
brandonroberts
approved these changes
Jun 15, 2023
OgDev-01
approved these changes
Jun 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2023
## [1.52.0-beta.6](v1.52.0-beta.5...v1.52.0-beta.6) (2023-06-16) ### 🍕 Features * handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7))
|
🎉 This PR is included in version 1.52.0-beta.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
## [1.53.0-beta.1](v1.52.0...v1.53.0-beta.1) (2023-06-20) ### 🍕 Features * handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7)) ### 🐛 Bug Fixes * link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16)) * remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))
|
🎉 This PR is included in version 1.53.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
## [1.53.0](v1.52.0...v1.53.0) (2023-06-22) ### 🍕 Features * handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7)) ### 🐛 Bug Fixes * language update - change developer to contributor ([#1274](#1274)) ([7e86ac9](7e86ac9)), closes [#1247](#1247) * link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16)) * properly format local time displayed on user's profile ([#1282](#1282)) ([604cc62](604cc62)) * remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))
|
🎉 This PR is included in version 1.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.52.0-beta.6](open-sauced/app@v1.52.0-beta.5...v1.52.0-beta.6) (2023-06-16) ### 🍕 Features * handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.53.0-beta.1](open-sauced/app@v1.52.0...v1.53.0-beta.1) (2023-06-20) ### 🍕 Features * handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7)) ### 🐛 Bug Fixes * link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16)) * remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.53.0](open-sauced/app@v1.52.0...v1.53.0) (2023-06-22) ### 🍕 Features * handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7)) ### 🐛 Bug Fixes * language update - change developer to contributor ([#1274](open-sauced/app#1274)) ([7e86ac9](open-sauced/app@7e86ac9)), closes [#1247](open-sauced/app#1247) * link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16)) * properly format local time displayed on user's profile ([#1282](open-sauced/app#1282)) ([604cc62](open-sauced/app@604cc62)) * remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR fixes a bug where the single highlight dialog was not being closed after clicking the close button or the overlay. The
setOpenSingleHighlightstate is now properly updated when the highlight modal is closed.Generated using OpenSauced.
Related Tickets & Documents
Fixes #1267
Mobile & Desktop Screenshots/Recordings
Before
close-dialog-before.mp4
After
close-dialog-after.mp4
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?