fix: properly format local time displayed on user's profile #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
OgDev-01
approved these changes
Jun 21, 2023
|
@OgDev-01 there is another issue with the time format. The hour's value should not be greater than 11 in the case of "PM". Should I open a new issue to fix that or can I fix it within this PR as an additional improvement? |
Since it's a tiny change, adding it here won't hurt 😇😇 |
brandonroberts
requested changes
Jun 21, 2023
brandonroberts
changed the title
brandonroberts
changed the title
codewithshariq
force-pushed
the
fixes-localtime-format
branch
from
2a0ef50 to
616e1f2
Compare
NsdHSO
reviewed
Jun 22, 2023
Co-authored-by: ( Nechiforel David-Samuel ) NsdHSO <37635083+NsdHSO@users.noreply.github.com>
brandonroberts
approved these changes
Jun 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
## [1.53.0-beta.3](v1.53.0-beta.2...v1.53.0-beta.3) (2023-06-22) ### 🐛 Bug Fixes * properly format local time displayed on user's profile ([#1282](#1282)) ([604cc62](604cc62))
|
🎉 This PR is included in version 1.53.0-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
## [1.53.0](v1.52.0...v1.53.0) (2023-06-22) ### 🍕 Features * handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7)) ### 🐛 Bug Fixes * language update - change developer to contributor ([#1274](#1274)) ([7e86ac9](7e86ac9)), closes [#1247](#1247) * link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16)) * properly format local time displayed on user's profile ([#1282](#1282)) ([604cc62](604cc62)) * remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))
|
🎉 This PR is included in version 1.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.53.0-beta.3](open-sauced/app@v1.53.0-beta.2...v1.53.0-beta.3) (2023-06-22) ### 🐛 Bug Fixes * properly format local time displayed on user's profile ([#1282](open-sauced/app#1282)) ([604cc62](open-sauced/app@604cc62))
ElpisHelle
added a commit
to ElpisHelle/next.js-tailwindcss
that referenced
this pull request
Aug 17, 2023
## [1.53.0](open-sauced/app@v1.52.0...v1.53.0) (2023-06-22) ### 🍕 Features * handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7)) ### 🐛 Bug Fixes * language update - change developer to contributor ([#1274](open-sauced/app#1274)) ([7e86ac9](open-sauced/app@7e86ac9)), closes [#1247](open-sauced/app#1247) * link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16)) * properly format local time displayed on user's profile ([#1282](open-sauced/app#1282)) ([604cc62](open-sauced/app@604cc62)) * remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"fix #1275"
What type of PR is this? (check all applicable)
Description
This PR fixes the issue related to local time formatting on the user's profile, the local time is properly formatted on the user's profile. If the minutes are less than 10, then a leading zero will be displayed and time will be properly displayed in 12 hours format.
Related Tickets & Documents
Fixes #1275
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?