fix: linked single highlight dialog's contributor info div to contributor profile #1279

babblebey · 2023-06-19T18:02:11Z

What type of PR is this? (check all applicable)

Description

This PR Links the Contributor Info div (which contains the contributor's Avatar component and login/username) on the single highlight Dialog component to the contributor's profile on route /user/[username]

Code Sample

// pages\feed\index.tsx

<Link href={`/user/${singleHighlight.login}`} className="flex items-center gap-3">
  <Avatar
    alt="user profile avatar"
    isCircle
    size="sm"
    avatarURL={`https://www.github.com/${singleHighlight.login}.png?size=300`}
  />
  <strong>{singleHighlight.login}</strong>
</Link>

Related Tickets & Documents

Fixes #1276

Mobile & Desktop Screenshots/Recordings

Before
https://github-production-user-asset-6210df.s3.amazonaws.com/25631971/246900915-847f8e76-4f74-4b39-b113-6a0e6cdb3dc6.webm

After
https://github-production-user-asset-6210df.s3.amazonaws.com/25631971/246901000-f1e27d4e-e1fe-4b33-bb05-04c3a71df804.webm

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

None

[optional] What gif best describes this PR or how it makes you feel?

🙏

…n) div to contributor profile

netlify · 2023-06-19T18:02:16Z

✅ Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`f86b070`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/649098250efb0a0008c7ad18
😎 Deploy Preview	https://deploy-preview-1279--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-06-19T18:02:24Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`f86b070`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/64909825f19dde000877bc7f
😎 Deploy Preview	https://deploy-preview-1279--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions

PR Compliance Checks Passed!

OgDev-01

Works as expected! 🍕

brandonroberts · 2023-06-20T13:22:37Z

Thanks @babblebey!

## [1.52.0-beta.7](v1.52.0-beta.6...v1.52.0-beta.7) (2023-06-20) ### 🐛 Bug Fixes * link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16)) * remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))

github-actions · 2023-06-20T13:28:07Z

🎉 This PR is included in version 1.52.0-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.53.0-beta.1](v1.52.0...v1.53.0-beta.1) (2023-06-20) ### 🍕 Features * handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7)) ### 🐛 Bug Fixes * link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16)) * remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))

github-actions · 2023-06-20T13:34:45Z

🎉 This PR is included in version 1.53.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.53.0](v1.52.0...v1.53.0) (2023-06-22) ### 🍕 Features * handle close highlight dialog ([#1268](#1268)) ([b6a78c7](b6a78c7)) ### 🐛 Bug Fixes * language update - change developer to contributor ([#1274](#1274)) ([7e86ac9](7e86ac9)), closes [#1247](#1247) * link single highlight dialog contributor info div to contributor profile ([#1279](#1279)) ([67d5a16](67d5a16)) * properly format local time displayed on user's profile ([#1282](#1282)) ([604cc62](604cc62)) * remove failing maintenance actions ([#1271](#1271)) ([bc516c3](bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](#1266)) ([ec6b3d5](ec6b3d5))

github-actions · 2023-06-22T17:09:18Z

🎉 This PR is included in version 1.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.52.0-beta.7](open-sauced/app@v1.52.0-beta.6...v1.52.0-beta.7) (2023-06-20) ### 🐛 Bug Fixes * link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16)) * remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))

## [1.53.0-beta.1](open-sauced/app@v1.52.0...v1.53.0-beta.1) (2023-06-20) ### 🍕 Features * handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7)) ### 🐛 Bug Fixes * link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16)) * remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))

## [1.53.0](open-sauced/app@v1.52.0...v1.53.0) (2023-06-22) ### 🍕 Features * handle close highlight dialog ([#1268](open-sauced/app#1268)) ([b6a78c7](open-sauced/app@b6a78c7)) ### 🐛 Bug Fixes * language update - change developer to contributor ([#1274](open-sauced/app#1274)) ([7e86ac9](open-sauced/app@7e86ac9)), closes [#1247](open-sauced/app#1247) * link single highlight dialog contributor info div to contributor profile ([#1279](open-sauced/app#1279)) ([67d5a16](open-sauced/app@67d5a16)) * properly format local time displayed on user's profile ([#1282](open-sauced/app#1282)) ([604cc62](open-sauced/app@604cc62)) * remove failing maintenance actions ([#1271](open-sauced/app#1271)) ([bc516c3](open-sauced/app@bc516c3)) * scatter plot tooltip issue and remove cloudinary rounded image solution ([#1266](open-sauced/app#1266)) ([ec6b3d5](open-sauced/app@ec6b3d5))

fix: linked single highlight contributor info (avatar & username/logi…

f86b070

…n) div to contributor profile

github-actions bot reviewed Jun 19, 2023

View reviewed changes

OgDev-01 requested a review from brandonroberts June 20, 2023 12:14

OgDev-01 approved these changes Jun 20, 2023

View reviewed changes

OgDev-01 added the needs review PRs that need review from core engineering team label Jun 20, 2023

brandonroberts approved these changes Jun 20, 2023

View reviewed changes

brandonroberts merged commit 67d5a16 into open-sauced:beta Jun 20, 2023

github-actions bot added the released on @beta label Jun 20, 2023

github-actions bot added the released label Jun 22, 2023

babblebey deleted the fix--link-to-contributor-profile-from-single-highlight-dialogue branch July 31, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: linked single highlight dialog's contributor info div to contributor profile #1279

fix: linked single highlight dialog's contributor info div to contributor profile #1279

babblebey commented Jun 19, 2023 •

edited

Loading

netlify bot commented Jun 19, 2023 •

edited

Loading

netlify bot commented Jun 19, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading

OgDev-01 left a comment

brandonroberts commented Jun 20, 2023

github-actions bot commented Jun 20, 2023

github-actions bot commented Jun 20, 2023

github-actions bot commented Jun 22, 2023

fix: linked single highlight dialog's contributor info div to contributor profile #1279

fix: linked single highlight dialog's contributor info div to contributor profile #1279

Conversation

babblebey commented Jun 19, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Jun 19, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Jun 19, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

OgDev-01 left a comment

Choose a reason for hiding this comment

brandonroberts commented Jun 20, 2023

github-actions bot commented Jun 20, 2023

github-actions bot commented Jun 20, 2023

github-actions bot commented Jun 22, 2023

babblebey commented Jun 19, 2023 •

edited

Loading

netlify bot commented Jun 19, 2023 •

edited

Loading

netlify bot commented Jun 19, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading