-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v10.15.1 proposal #25346
v10.15.1 proposal #25346
Commits on Dec 26, 2018
-
src: remove function hasTextDecoder in encoding.js
also... return TextDecoder directly from factories PR-URL: #23625 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ffb4087 - Browse repository at this point
Copy the full SHA ffb4087View commit details -
crypto: reduce memory usage of SignFinal
The fixed-size buffer on the stack is unnecessary and way too large for most applications. This change removes it and allocates the required memory directly instead of copying into heap later. PR-URL: #23427 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4749640 - Browse repository at this point
Copy the full SHA 4749640View commit details -
PR-URL: #23734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6a43fa - Browse repository at this point
Copy the full SHA c6a43faView commit details -
src: memory management using smart pointer
Introduced use of smart pointers instead of MallocedBuffer to manage memory allocated in the cares library. PR-URL: #23628 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 383d512 - Browse repository at this point
Copy the full SHA 383d512View commit details -
src: simplify
TimerFunctionCall()
innode_perf.cc
Picking a path according to a boolean is essentially free, compared to the cost of a function call. Also, remove an unnecessary `TryCatch`. PR-URL: #23782 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 15d05bb - Browse repository at this point
Copy the full SHA 15d05bbView commit details -
tls: throw if protocol too long
The convertProtocols() function now throws a range error when the byte length of a protocol is too long to fit in a Buffer. Also added a test case in test/parallel/test-tls-basic-validations.js to cover this. PR-URL: #23606 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3170cb4 - Browse repository at this point
Copy the full SHA 3170cb4View commit details -
doc, test: document and test vm timeout escapes
Using `process.nextTick()` or `Promise`, it is possible to escape the `timeout` set when running code with `vm.runInContext()`, `vm.runInThisContext()`, and `vm.runInNewContext()`. This documents the issue and adds two known_issues tests. Refs: #3020 PR-URL: #23743 Refs: #3020 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6f3bc0d - Browse repository at this point
Copy the full SHA 6f3bc0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b16311b - Browse repository at this point
Copy the full SHA b16311bView commit details -
build: expose more openssl categories for addons
Those categories are necessary to build addons that depends on libcurl and libssh, the following were the missing symbols: libcurl: OCSP_cert_status_str OCSP_check_validity OCSP_basic_verify OCSP_RESPONSE_free OCSP_single_get0_status OCSP_response_get1_basic OCSP_BASICRESP_free OCSP_crl_reason_str OCSP_resp_count OCSP_response_status OCSP_response_status_str OCSP_resp_get0 d2i_OCSP_RESPONSE SSL_CTX_set_next_proto_select_cb libssh: EVP_ripemd160 EVP_cast5_cbc Fixes: #23293 PR-URL: #23344 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72d2d2c - Browse repository at this point
Copy the full SHA 72d2d2cView commit details -
src: avoid extra
Persistent
inDefaultTriggerAsyncIdScope
Instead of getting a reference to the main `AliasedBuffer`, which would always unnecesarily allocate and destroy a `Persistent` handle, store and use a reference to the owning object. PR-URL: #23844 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Configuration menu - View commit details
-
Copy full SHA for 44a1993 - Browse repository at this point
Copy the full SHA 44a1993View commit details -
build: only try to find node when it's needed by the target
Right now `node -p process.versions.openssl` always gets run in the Makefile even when it's not needed by the target (e.g. `make clean`, `make test-only`). This patch makes it a run time call instead of part of the global expansion. PR-URL: #24115 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 042749f - Browse repository at this point
Copy the full SHA 042749fView commit details -
test: http-client-timeout error assert arguments
PR-URL: #24130 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 74f1dad - Browse repository at this point
Copy the full SHA 74f1dadView commit details -
PR-URL: #24131 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for c37b319 - Browse repository at this point
Copy the full SHA c37b319View commit details -
child_process: allow 'http_parser' monkey patching again
Lazy load _http_common and HTTPParser so that the 'http_parser' binding can be monkey patched before any internal modules require it. This also probably improves startup performance minimally for programs that never require the HTTP stack. Fixes: #23716 Fixes: creationix/http-parser-js#57 PR-URL: #24006 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 04f8d6b - Browse repository at this point
Copy the full SHA 04f8d6bView commit details -
test: fs readfile, swap arguments in strictEqual
PR-URL: #24133 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e599889 - Browse repository at this point
Copy the full SHA e599889View commit details -
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()` calls. Arguments are now in correct order. Literal value is now the second argument and the value returned by the function is the first argument. PR-URL: #24134 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 11a84a7 - Browse repository at this point
Copy the full SHA 11a84a7View commit details -
test: strictEqual argument order (actual, expected)
PR-URL: #24137 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2d88af3 - Browse repository at this point
Copy the full SHA 2d88af3View commit details -
test: fix invalid argument order in test-http-expect-continue.js
`assert.strictEqual` expects arguments in the following order: actual, expected[, message] PR-URL: #24138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 64fd19f - Browse repository at this point
Copy the full SHA 64fd19fView commit details -
test: change order of assert.strictEqual()
PR-URL: #24142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 78a3201 - Browse repository at this point
Copy the full SHA 78a3201View commit details -
test: fix assert parameter order
Switched arguments in assert.strictEqual() PR-URL: #24144 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for f0eee63 - Browse repository at this point
Copy the full SHA f0eee63View commit details -
test: swap expected and actual in assert.strictEqual
PR-URL: #24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for abf9bd1 - Browse repository at this point
Copy the full SHA abf9bd1View commit details -
test: add tests for OutgoingMessage setTimeout
These tests ensure that OutgoingMessage setTimeout method will call setTimeout on its socket Co-authored-by: ZauberNerd <zaubernerd@zaubernerd.de> PR-URL: #24148 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6e8fa53 - Browse repository at this point
Copy the full SHA 6e8fa53View commit details -
test: fixing arguments order in
assert.strictEqual()
PR-URL: #24152 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd07b02 - Browse repository at this point
Copy the full SHA cd07b02View commit details -
test: fixe argument order in assert.strictEqual
File: test/parallel/test-http-client-upload-buf.js PR-URL: #24140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 380789e - Browse repository at this point
Copy the full SHA 380789eView commit details -
the actual and expected arguments in assert.strictEqual() calls are in the wrong order. Any literal value should be the second argument while the first argument should be the value returned by a function/be the calculated value. PR-URL: #24151 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f2bdac - Browse repository at this point
Copy the full SHA 8f2bdacView commit details -
test: switch arguments in strictEqual
In the `test/parallel/test-vm-create-and-run-in-context.js` test the actual and expected arguments in the `assert.strictEqual()` call on line 32 are in the wrong order and they have to be switched around. PR-URL: #24141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f46fa90 - Browse repository at this point
Copy the full SHA f46fa90View commit details -
test: fix argument order in assert.strictEqual()
PR-URL: #24147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1588fba - Browse repository at this point
Copy the full SHA 1588fbaView commit details -
test: fix arguments order in test-fs-write-buffer
PR-URL: #24155 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 90f9890 - Browse repository at this point
Copy the full SHA 90f9890View commit details -
test: removed extraneous argument 's'
PR-URL: #24213 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fc84ccd - Browse repository at this point
Copy the full SHA fc84ccdView commit details -
test: fix assert argument order
PR-URL: #24160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for e0c6f5c - Browse repository at this point
Copy the full SHA e0c6f5cView commit details -
test: fix arguments order in assert.strictEqual
In the test test/parallel/test-http-client-upload.js test the actual and expected arguments in assert.strictEqual() calls were in the wrong order. Switched them around so the returned value by the function is the first argument and the literal value is the second argument. PR-URL: #24143 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b63e9cb - Browse repository at this point
Copy the full SHA b63e9cbView commit details -
test: fix order in assert.strictEqual to actual, expected
PR-URL: #24184 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2e0d3c9 - Browse repository at this point
Copy the full SHA 2e0d3c9View commit details -
test: fix the arguments order in
assert.strictEqual
This change was initiated from the NodeConfEU session. PR-URL: #24226 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d7722dd - Browse repository at this point
Copy the full SHA d7722ddView commit details -
test: fix the arguments order in
assert.strictEqual
This change was initiated from the NodeConfEU session. PR-URL: #24227 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9052a22 - Browse repository at this point
Copy the full SHA 9052a22View commit details -
doc: fix some inconsistent use of hostname
host names are DNS names, host addresses are IP addresses, and `host` arguments and options can be either. PR-URL: #24199 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc688bb - Browse repository at this point
Copy the full SHA cc688bbView commit details -
test: switch order of strictEqual arguments
PR-URL: #24185 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for efd697b - Browse repository at this point
Copy the full SHA efd697bView commit details -
test: change arguments order in strictEqual
Fix actual/expected ordering in test-net-eaddrinuse. PR-URL: #24156 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d7a3a3b - Browse repository at this point
Copy the full SHA d7a3a3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a64cec - Browse repository at this point
Copy the full SHA 9a64cecView commit details -
test: fix order of arguments in test-delayed-require assertion
Fix order of arguments in equality assertion in test-delayed-require. PR-URL: #24165 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for e57a5c3 - Browse repository at this point
Copy the full SHA e57a5c3View commit details -
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments. PR-URL: #24215 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e9ff69 - Browse repository at this point
Copy the full SHA 8e9ff69View commit details -
url: make the context non-enumerable
At the moment we expose the context as a normal property on the prototype chain of URL or take them from the base URL which makes them enumerable and considered by assert libraries even though the context carries path-dependent information that do not affect the equivalence of these objects. This patch fixes it in a minimal manner by marking the context non-enumerable as making it full private would require more refactoring and can be done in a bigger patch later. PR-URL: #24218 Refs: #24211 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c107a3 - Browse repository at this point
Copy the full SHA 8c107a3View commit details -
benchmark: support more options in startup benchmark
1. Add options to benchmark the startup performance of a node "instance" after running a script. By default there are two options: `test/fixtures/semicolon` which is basically an empty file, and `benchmark/fixtures/require-cachable` which require all the cachable modules before exiting. This allows us to measure the overhead of bootstrap in more scenarios. 2. Add options to benchmark the overhead of spinning node through a process and through a worker. PR-URL: #24220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 0c206e0 - Browse repository at this point
Copy the full SHA 0c206e0View commit details -
doc: describe what tls servername is for
Docs should describe the purpose of the option. PR-URL: #24236 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 31441f4 - Browse repository at this point
Copy the full SHA 31441f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a69d03 - Browse repository at this point
Copy the full SHA 9a69d03View commit details -
test: fix NewFromUtf8 compiler warning
Currently there are a number of compiler warnings like the following: ../binding.cc:6:41: warning: 'NewFromUtf8' is deprecated: Use maybe version [-Wdeprecated-declarations] args.GetReturnValue().Set(v8::String::NewFromUtf8(isolate, "world")); ^ /node/deps/v8/include/v8.h:2883:10: note: 'NewFromUtf8' has been explicitly marked deprecated here static V8_DEPRECATE_SOON( ^ /node/deps/v8/include/v8config.h:341:29: note: expanded from macro 'V8_DEPRECATE_SOON' declarator __attribute__((deprecated(message))) ^ This commit updates the code to use the maybe versions. PR-URL: #24216 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 53b12c3 - Browse repository at this point
Copy the full SHA 53b12c3View commit details -
test: add coverage for escape key switch case
PR-URL: #24194 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 540b741 - Browse repository at this point
Copy the full SHA 540b741View commit details -
test: add test for 'ERR_INVALID_CALLBACK'
PR-URL: #24224 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 2d6e942 - Browse repository at this point
Copy the full SHA 2d6e942View commit details -
doc: fix code examples in stream.md
* Replace `console.error()` with `console.log()`. * Fix case and punctuation in logged output. PR-URL: #24112 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for abe3eda - Browse repository at this point
Copy the full SHA abe3edaView commit details -
tracing: fix static destruction order issue
Sometimes, the `parallel/test-tracing-no-crash` would not work as expected, at least on Windows, because there is a static destruction race between tearing down the `NodeTraceWriter` instance and the per-process options struct. If the per-process options were destroyed before the `NodeTraceWriter`, the reference to the tracing filename would be gone before opening the file was attempted. This can be solved by creating a copy of the string when creating the `NodeTraceWriter` instance rather than taking a reference. Fixes: #22523 PR-URL: #24123 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a1d7ed7 - Browse repository at this point
Copy the full SHA a1d7ed7View commit details -
test: fix order of arguments in assert.strictEqual
PR-URL: #24145 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 9fa7146 - Browse repository at this point
Copy the full SHA 9fa7146View commit details -
test: add coverage for systemerror set name
PR-URL: #24200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for cd2dedf - Browse repository at this point
Copy the full SHA cd2dedfView commit details -
test: add test for strictDeepEqual
PR-URL: #24197 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1b5b1cc - Browse repository at this point
Copy the full SHA 1b5b1ccView commit details -
test: use assert.strictEqual instead of assert.equal
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c417c7a - Browse repository at this point
Copy the full SHA c417c7aView commit details -
test: fix uses of deprecated assert.fail with multiple args
PR-URL: #23673 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4054c24 - Browse repository at this point
Copy the full SHA 4054c24View commit details -
Minor edits to BUILDING.md to keep sentences short and clear. PR-URL: #24243 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b305db8 - Browse repository at this point
Copy the full SHA b305db8View commit details -
test: move test-fs-watch-system-limit from sequential to pummel
PR-URL: #23692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4b9518d - Browse repository at this point
Copy the full SHA 4b9518dView commit details -
lib: combine contructor, tag, Object into a function
combine these parts into a function to be used in multiple parts PR-URL: #24171 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 3966b69 - Browse repository at this point
Copy the full SHA 3966b69View commit details -
build,tools: update make-v8.sh for s390x
PR-URL: #23839 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5dfc1bb - Browse repository at this point
Copy the full SHA 5dfc1bbView commit details -
test: use NULL instead of 0 in common.h
This commit updates the macros in test/addons-napi/common.h to use NULL instead of 0. This is very minor, but I had to look twice while going through the code and finding what the macro was doing and comparing with the struct definition. Using NULL makes it a little clearer I think. PR-URL: #24104 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d8ac55a - Browse repository at this point
Copy the full SHA d8ac55aView commit details -
net: simplify Socket.prototype._final
Remove conditions that should be irrelevant since we started using `_final`, as well as an extra `defaultTriggerAsyncIdScope()` call which is unnecessary because there is an equivalent scope already present on the native side. PR-URL: #24075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 10a2727 - Browse repository at this point
Copy the full SHA 10a2727View commit details -
test: increase coverage internal readline
PR-URL: #24150 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 704b68a - Browse repository at this point
Copy the full SHA 704b68aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 897114b - Browse repository at this point
Copy the full SHA 897114bView commit details -
stream: make
.destroy()
interact better with write queueMake sure that it is safe to call the callback for `_write()` even in the presence of `.destroy()` calls during that write. In particular, letting the write queue continue processing would previously have thrown an exception, because processing writes after calling `.destroy()` is forbidden. One test had to be modified to account for the fact that callbacks for writes will now always be called, even when the stream is destroyed during the process. PR-URL: #24062 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ce4ef3 - Browse repository at this point
Copy the full SHA 6ce4ef3View commit details -
test: replacing fixture directory with temp
PR-URL: #24077 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a6f786d - Browse repository at this point
Copy the full SHA a6f786dView commit details -
build: lint commit message in separate Travis job
Move the first commit message linting to a separate Travis job. Run the script in bash debug mode to capture any issues communicating with the GitHub API (e.g. network issues, rate limits). PR-URL: #24254 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Configuration menu - View commit details
-
Copy full SHA for 4e21eb4 - Browse repository at this point
Copy the full SHA 4e21eb4View commit details -
test : compare objects not identical by reference
PR-URL: #24189 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1ec6923 - Browse repository at this point
Copy the full SHA 1ec6923View commit details -
test: fix assert.strictEqual argument order
The arguments to assert.strictEqual in a number of calls were in the wrong order. It is preferred that literal values are in the second argument. Updates test/parallel/test-fs-readStream.js PR-URL: #24172 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3bb6372 - Browse repository at this point
Copy the full SHA 3bb6372View commit details -
test: fix arguments order in assert.strictEqual()
PR-URL: #24192 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2359273 - Browse repository at this point
Copy the full SHA 2359273View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8d2635 - Browse repository at this point
Copy the full SHA c8d2635View commit details -
test: add test for deepEqual Float32Array
PR-URL: #24164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dd67f39 - Browse repository at this point
Copy the full SHA dd67f39View commit details -
test: add test case for completion bash flag
This test case verifies that starting Node.js with the completion bash flag prints out the expected result and ends right after. PR-URL: #24168 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 63dc221 - Browse repository at this point
Copy the full SHA 63dc221View commit details -
doc: correct async_hooks sample outputs
Correct the output of async_hooks samples * `TIMERWRAP` has been removed in #20894 * `console.log()` doesn't issue `TTYWRAP` nor `SIGNALWRAP` I don't know which PR caused that `console.log()` is no longer using `TTYWRAP` and `SIGNALWRAP`; I think it was between 8.4.0 and 8.5.0. PR-URL: #24050 Refs: #20894 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0260db5 - Browse repository at this point
Copy the full SHA 0260db5View commit details -
test: correct order of args in assert.strictEqual()
Ensure literal values are passed in as second argument PR-URL: #24157 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 704d886 - Browse repository at this point
Copy the full SHA 704d886View commit details -
doc: add links to Stream section
PR-URL: #24301 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf20917 - Browse repository at this point
Copy the full SHA cf20917View commit details -
console: cover .assert with single argument
PR-URL: #24188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 07b9a66 - Browse repository at this point
Copy the full SHA 07b9a66View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c1d82 - Browse repository at this point
Copy the full SHA b4c1d82View commit details -
test: fix strictEqual argument order
Fix the order of assert.strictEqual() arguments. It should have first argument as the calculated/tested value. PR-URL: #24153 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 09bb491 - Browse repository at this point
Copy the full SHA 09bb491View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2cc9d7 - Browse repository at this point
Copy the full SHA d2cc9d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4209e12 - Browse repository at this point
Copy the full SHA 4209e12View commit details -
Original commit message: [turbofan] Fix ObjectCreate's side effect annotation. Bug: chromium:888923 Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79 Reviewed-on: https://chromium-review.googlesource.com/1245763 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56236} Refs: v8/v8@52a9e67 PR-URL: #25027 Refs: v8/v8@52a9e67 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 17b55bf - Browse repository at this point
Copy the full SHA 17b55bfView commit details -
test: move benchmark tests out of main test suite
Move benchmark tests (which are slow) out of the main test suite. We can hopefully add them to node-daily-master so that they are still run daily on CI. Backport-PR-URL: #25049 PR-URL: #24265 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d04c3c2 - Browse repository at this point
Copy the full SHA d04c3c2View commit details
Commits on Dec 30, 2018
-
In 180f865, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: #21451 Fixes: nodejs/build#1377 Refs: #25219 PR-URL: #25226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1bceb9d - Browse repository at this point
Copy the full SHA 1bceb9dView commit details
Commits on Jan 12, 2019
-
test: fix flaky test-vm-timeout-escape-nexttick
Increase the VM timeout. If it is too small, the VM does not exit before the code has a chance to create the problematic condition that causes the timeout to be ignored. Fixes: #24120 PR-URL: #24251 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for a30f5a0 - Browse repository at this point
Copy the full SHA a30f5a0View commit details -
doc: clarify allowed encoding parameter types
This fixes the incorrect enumerations of their possible values, which weren't up to date with the values actually supported. Also renamed two arguments that used "format" when they meant "encoding". PR-URL: #24230 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 90f3f5e - Browse repository at this point
Copy the full SHA 90f3f5eView commit details -
test: fix v8 Set/Get compiler warnings
PR-URL: #24246 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4d1a803 - Browse repository at this point
Copy the full SHA 4d1a803View commit details -
build: use BUILDTYPE in bench-addons-build targets
This commit uses the BUILDTYPE for the benchmark targets that currently explicitly use Release as the build type. The motivation for this change is allows switching between debug builds and release builds using the bench-addons-clean/bench-addons-build targets. PR-URL: #24033 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 07b7db2 - Browse repository at this point
Copy the full SHA 07b7db2View commit details -
test: check control characters replacing
Add test that creates an error with a control character in the message. PR-URL: #24182 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 454ede2 - Browse repository at this point
Copy the full SHA 454ede2View commit details -
test: fix args order in process-getactiverequests
PR-URL: #24186 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 51643c2 - Browse repository at this point
Copy the full SHA 51643c2View commit details -
deps: cherry-pick b87d408 from upstream V8
Original commit message: [heap-profiler] Fix a use-after-free when snapshots are deleted If a caller starts the sampling heap profiler and takes a snapshot, and then deletes the snapshot before the sampling has completed, a use-after-free will occur on the StringsStorage pointer. The same issue applies for StartTrackingHeapObjects which shares the same StringsStorage object. Bug: v8:8373 Change-Id: I5d69d60d3f9465f9dd3b3bef107c204e0fda0643 Reviewed-on: https://chromium-review.googlesource.com/c/1301477 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#57114} PR-URL: #24272 Refs: v8/v8@b87d408 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 733cb1e - Browse repository at this point
Copy the full SHA 733cb1eView commit details -
test: test add and remove for lib/domain
Testing some of the more specific cases of using domain.add and domain.remove. For example, calling domain.add twice with same event emmiter and actually removing an event emitter from the domain. PR-URL: #24163 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 9970d56 - Browse repository at this point
Copy the full SHA 9970d56View commit details -
test: url format path ending hashchar not covered
PR-URL: #24259 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aba7b47 - Browse repository at this point
Copy the full SHA aba7b47View commit details -
lib: adjust params from uvExceptionWithHostPort
PR-URL: #24159 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 7527632 - Browse repository at this point
Copy the full SHA 7527632View commit details -
build: fix benchmark tests on CI
PR-URL: #24307 Refs: nodejs/build#1568 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 33fd13c - Browse repository at this point
Copy the full SHA 33fd13cView commit details -
test: add else and error case for TextDecoder
add test for tinyurl.com/codeandlearn-encoding-1 add test for tinyurl.com/codeandlearn-encoding-2 PR-URL: #24162 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for e21d784 - Browse repository at this point
Copy the full SHA e21d784View commit details -
test: fixed order of actual and expected arguments
PR-URL: #24178 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 8728361 - Browse repository at this point
Copy the full SHA 8728361View commit details -
test: esm loader unknown builtin module
PR-URL: #24183 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 817d871 - Browse repository at this point
Copy the full SHA 817d871View commit details -
test: remove unused parameters in function definition
Remove unused parameters triggerAsyncId and resource from oninit function in test-async-await.js. PR-URL: #24268 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for d4fd76a - Browse repository at this point
Copy the full SHA d4fd76aView commit details -
test: fix arguments order in assertions
Have the actual value first & the expected value second. PR-URL: #24149 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for b29b235 - Browse repository at this point
Copy the full SHA b29b235View commit details -
http: remove obsolete function escapeHeaderValue
There are test cases which validate the useful path of the function never runs the functionality of it is obsoleted by checkInvalidHeaderChar PR-URL: #24173 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 35d2397 - Browse repository at this point
Copy the full SHA 35d2397View commit details -
doc: fix echo example programs
Adjust to work with self-signed certificates, and certificates that do not name "localhost" as their host name. Removed duplicate examples, they differed only by using `pfx`. Its not necessary to show every option, and we don't, and the example wouldn't work with most pfx anyway, since it didn't specify a password. PR-URL: #24235 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a9a6cb1 - Browse repository at this point
Copy the full SHA a9a6cb1View commit details -
doc: update core-validate-commit url
PR-URL: #24331 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8a60798 - Browse repository at this point
Copy the full SHA 8a60798View commit details -
util: deleted unreachable code from util.inspect
PR-URL: #24187 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 7576a51 - Browse repository at this point
Copy the full SHA 7576a51View commit details -
test: add process no deprecation
PR-URL: #24196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for fbdfd60 - Browse repository at this point
Copy the full SHA fbdfd60View commit details -
Update ESLint to 5.9.0. PR-URL: #24280 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 39ccf14 - Browse repository at this point
Copy the full SHA 39ccf14View commit details -
async_hooks: add HandleScopes to C++ embedder/addon API
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`. PR-URL: #24285 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for fbf5321 - Browse repository at this point
Copy the full SHA fbf5321View commit details -
doc: use real protocol names in ALPN example
PR-URL: #24232 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 672879f - Browse repository at this point
Copy the full SHA 672879fView commit details -
net: remove unreachable check in internalConnect
Checked all call-sites to ensure that this code is truly unreachable. addressType is always checked before internalConnect is even called. PR-URL: #24158 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 2d0105c - Browse repository at this point
Copy the full SHA 2d0105cView commit details -
net: add comments explaining error check
PR-URL: #24222 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c2d1d5 - Browse repository at this point
Copy the full SHA 0c2d1d5View commit details -
test: add tests for Socket.setNoDelay
PR-URL: #24250 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 916ead9 - Browse repository at this point
Copy the full SHA 916ead9View commit details -
doc: fix comma splices in process.md
PR-URL: #24357 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ac3e264 - Browse repository at this point
Copy the full SHA ac3e264View commit details -
doc: clarify issues and pull requests guidance
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: #24316 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 68aecff - Browse repository at this point
Copy the full SHA 68aecffView commit details -
doc: document NODE_TLS_REJECT_UNAUTHORIZED
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED environment variable so that the world can know how potentially dangerous it is. PR-URL: #24289 Fixes: #24284 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1ca3c9d - Browse repository at this point
Copy the full SHA 1ca3c9dView commit details -
doc: document http request.finished boolean
PR-URL: #24319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e111d71 - Browse repository at this point
Copy the full SHA e111d71View commit details -
test: deep object to table not covered
PR-URL: #24257 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 6cad1b6 - Browse repository at this point
Copy the full SHA 6cad1b6View commit details -
lib: improved conditional check in zlib
PR-URL: #24190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 5c2c5b9 - Browse repository at this point
Copy the full SHA 5c2c5b9View commit details -
test: add typeerror for vm/compileFunction params
PR-URL: #24179 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 585db59 - Browse repository at this point
Copy the full SHA 585db59View commit details -
stream: change comment on duplex stream options
'options.XXX' did not convey to me how to use camelCase for different readable and writable options on a duplex stream. Give an example instead. PR-URL: #24247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 965098a - Browse repository at this point
Copy the full SHA 965098aView commit details -
lib: gather all errors constant in the same place for consistency
PR-URL: #24038 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3450a4c - Browse repository at this point
Copy the full SHA 3450a4cView commit details
Commits on Jan 29, 2019
-
build: remove unnecessary prerequisite in Makefile
bench-addons-build is not needed by test-ci. PR-URL: #24342 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 31376d9 - Browse repository at this point
Copy the full SHA 31376d9View commit details -
doc: update collaborator guide with LTS labels
PR-URL: #24379 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ae3a194 - Browse repository at this point
Copy the full SHA ae3a194View commit details -
tools: update remark version to v10 from v8
Including the below two updates: + https://github.com/remarkjs/remark/releases/tag/9.0.0 + https://github.com/remarkjs/remark/releases/tag/10.0.0 PR-URL: #24333 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2bed68f - Browse repository at this point
Copy the full SHA 2bed68fView commit details -
tools: update remark-lint to v6.0.3 from v6.0.2
PR-URL: #24333 Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e8e93df - Browse repository at this point
Copy the full SHA e8e93dfView commit details -
tools: fix
make lint-md-rollup
and run itPR-URL: #24333 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 21843c7 - Browse repository at this point
Copy the full SHA 21843c7View commit details -
tls: do not rely on 'drain' handlers in StreamWrap
`'drain'` event handlers may not be invoked if the stream is currently finishing. Instead, use the fact that we know when writes are active or not, and invoke the delayed shutdown handler from our own after-write callback. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c73221 - Browse repository at this point
Copy the full SHA 0c73221View commit details -
tls: destroy TLS socket if StreamWrap is destroyed
Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f6a952 - Browse repository at this point
Copy the full SHA 0f6a952View commit details -
Revert "net: partially revert "simplify Socket.prototype._final""
Configuration menu - View commit details
-
Copy full SHA for c84b420 - Browse repository at this point
Copy the full SHA c84b420View commit details -
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in two async-hooks tests. PR-URL: #24368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 987df27 - Browse repository at this point
Copy the full SHA 987df27View commit details -
build,tools: update make-v8.sh for ppc64le
PR-URL: #24293 Fixes: nodejs/build#1536 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dc5647f - Browse repository at this point
Copy the full SHA dc5647fView commit details -
doc: better linkage to node-addon-api
One of the comments we got at the N-API workshop at NodeConfEU was that we should have a better link to node-addon-api and the docs in the main API docs for N-API. The goal being to help people find node-addon-api and potentially start with the node-addon-api docs instead if they are using C++. This expands and strengthens the link along with a recommendation that starting with the node-addon-api docs might make sense. PR-URL: #24371 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c19d6e2 - Browse repository at this point
Copy the full SHA c19d6e2View commit details -
test: https agent clientcertengine coverage
PR-URL: #24248 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c81992 - Browse repository at this point
Copy the full SHA 8c81992View commit details -
test: use destructuring and remove unused arguments
Use destructuring consistently and remove unused function arguments in test-pipewrap.js PR-URL: #24375 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b6135f - Browse repository at this point
Copy the full SHA 3b6135fView commit details -
doc: adjusting formatting when printing
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Configuration menu - View commit details
-
Copy full SHA for e11d46c - Browse repository at this point
Copy the full SHA e11d46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d2dadc - Browse repository at this point
Copy the full SHA 5d2dadcView commit details -
src: elevate v8 namespaces of referenced artifacts
PR-URL: #24424 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fa52ba6 - Browse repository at this point
Copy the full SHA fa52ba6View commit details -
doc: simplify first-time contributors section of Collaborator Guide
PR-URL: #24387 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2734c20 - Browse repository at this point
Copy the full SHA 2734c20View commit details -
test: fixed the arguments order in
assert.strictEqual
PR-URL: #24414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 555ef65 - Browse repository at this point
Copy the full SHA 555ef65View commit details -
test:replace anonymous closure function
PR-URL: #24415 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 53973fd - Browse repository at this point
Copy the full SHA 53973fdView commit details -
http2: elevate v8 namespaces of repeated references
PR-URL: #24453 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5e3c679 - Browse repository at this point
Copy the full SHA 5e3c679View commit details -
test: use arrow functions for callbacks
PR-URL: #24444 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 518bc96 - Browse repository at this point
Copy the full SHA 518bc96View commit details -
test: replace callback functions with arrow functions
PR-URL: #24432 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf7bf27 - Browse repository at this point
Copy the full SHA cf7bf27View commit details -
test:replace anonymous closure for test-http-expect-handling.js
PR-URL: #24423 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f4c2d9e - Browse repository at this point
Copy the full SHA f4c2d9eView commit details -
test: change callback function to arrow function
PR-URL: #24421 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 39a561b - Browse repository at this point
Copy the full SHA 39a561bView commit details -
src: use smart pointers in cares_wrap.cc
PR-URL: #23813 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be14283 - Browse repository at this point
Copy the full SHA be14283View commit details -
test: skip test that use --tls-v1.x flags
Currently, configuring --without-ssl will cause the following test to fail: === release test-https-agent-additional-options === Path: parallel/test-https-agent-additional-options out/Release/node: bad option: --tls-v1.1 Command: out/Release/node --tls-v1.1 /node/test/parallel/test-https-agent-additional-options.js === release test-https-agent-session-eviction === Path: parallel/test-https-agent-session-eviction out/Release/node: bad option: --tls-v1.0 Command: out/Release/node --tls-v1.0 /node/test/parallel/test-https-agent-session-eviction.js This commit adds a check for the --tls-v.x flags and skips them if node was built without crypto support. PR-URL: #24376 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for d2d6287 - Browse repository at this point
Copy the full SHA d2d6287View commit details -
src: elevate repeated use of v8 namespaced type
PR-URL: #24427 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for bfde244 - Browse repository at this point
Copy the full SHA bfde244View commit details -
stream: do not use crypto.DEFAULT_ENCODING in lazy_transform.js
The default encoding can be retrieved via `require('internal/crypto/util').getDefaultEncoding` instead of the deprecated crypto.DEFAULT_ENCODING which triggers a warning. Background: The require chain goes like this: ``` internal/streams/lazy_transform.js -> crypto.js -> internal/crypto/cipher.js (uses LazyTransform in the global scope) -> internal/streams/lazy_transform.js ``` So when `internal/streams/lazy_transform.js` is required before `lib/crypto.js`, we have a circular dependency and since `internal/crypto/cipher.js` uses destructuring to use LazyTransform we will get an error. And it can also trigger a warning if lazy_transform.js is the first file that touches crypto.DEFAULT_ENCODING. PR-URL: #24396 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a7c1d09 - Browse repository at this point
Copy the full SHA a7c1d09View commit details -
test: swap actual&optional params
PR-URL: #24426 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf3bed5 - Browse repository at this point
Copy the full SHA bf3bed5View commit details -
lib: set stderr._destroy to dummyDestroy
This seems to be typo: we are setting stdout._destroy instead of stderr._destroy in the getter of stderr. PR-URL: #24398 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 62a5679 - Browse repository at this point
Copy the full SHA 62a5679View commit details -
test: fix actual parameter order for 'assert.strictEqual'
PR-URL: #24428 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c29c510 - Browse repository at this point
Copy the full SHA c29c510View commit details -
doc: update crypto examples to not use deprecated api
Updated Cipher and Decipher examples to not use deprecated `crypto.createCipher` and `crypto.createDecipher` in examples and instead use `createCipheriv` and `createDecipheriv`. Fixes: #24046 PR-URL: #24107 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7fd4ef7 - Browse repository at this point
Copy the full SHA 7fd4ef7View commit details -
test: remove unused function arguments in async-hooks tests
Remove unused function arguments in three async-hooks tests and improve test consistancy. PR-URL: #24406 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2d25cdd - Browse repository at this point
Copy the full SHA 2d25cddView commit details -
In test-net-write-callback.js, when process exits, we check callback count against the expected value. The assertion is written with the expected value first and actual value second, but that is the opposite of the documented argument order. Reverse them to be consistent with documentation. PR-URL: #24422 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52259d7 - Browse repository at this point
Copy the full SHA 52259d7View commit details -
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a620c25 - Browse repository at this point
Copy the full SHA a620c25View commit details -
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc4d866 - Browse repository at this point
Copy the full SHA cc4d866View commit details -
test: fix the arguments order in
assert.strictEqual
PR-URL: #24431 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ad224d - Browse repository at this point
Copy the full SHA 5ad224dView commit details -
test: change callback function to arrow function
PR-URL: #24419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 380da04 - Browse repository at this point
Copy the full SHA 380da04View commit details -
test: replace closure with arrow functions
PR-URL: #24438 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94d200f - Browse repository at this point
Copy the full SHA 94d200fView commit details -
events: extract listener check as a function
PR-URL: #24303 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be56fb7 - Browse repository at this point
Copy the full SHA be56fb7View commit details -
test: fix the arguments order in
assert.strictEqual
PR-URL: #24416 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for abe9778 - Browse repository at this point
Copy the full SHA abe9778View commit details -
test: fix arguments order in napi test_exception
PR-URL: #24413 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 644a9d6 - Browse repository at this point
Copy the full SHA 644a9d6View commit details -
test: replace anonymous closure functions with arrow function
PR-URL: #24417 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f7326c - Browse repository at this point
Copy the full SHA 8f7326cView commit details -
test: favor arrow functions in callbacks
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2ffbde3 - Browse repository at this point
Copy the full SHA 2ffbde3View commit details -
test: use print() function on both Python 2 and 3
PR-URL: #24485 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 40773c0 - Browse repository at this point
Copy the full SHA 40773c0View commit details -
build: use print() function in configure.py
PR-URL: #24484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c3736a - Browse repository at this point
Copy the full SHA 5c3736aView commit details -
test: change anonymous closure functions to arrow functions
PR-URL: #24418 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4425926 - Browse repository at this point
Copy the full SHA 4425926View commit details -
test: add typeerror test for EC crypto keygen
PR-URL: #24400 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94553b2 - Browse repository at this point
Copy the full SHA 94553b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 492e2a4 - Browse repository at this point
Copy the full SHA 492e2a4View commit details -
PR-URL: #24390 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4a16a4d - Browse repository at this point
Copy the full SHA 4a16a4dView commit details -
test: replace anonymous closure function with arrow function
PR-URL: #24435 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f129e2c - Browse repository at this point
Copy the full SHA f129e2cView commit details -
test: replace closure with arrow functions
PR-URL: #24440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 164069c - Browse repository at this point
Copy the full SHA 164069cView commit details -
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to `setupInspector` and remove the argument from `setupInspector`. PR-URL: #24446 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6bd055f - Browse repository at this point
Copy the full SHA 6bd055fView commit details -
util: remove unreachable branch
Re-defining the array length will always set to 0. Hence, the code branch can not be covered. PR-URL: #24447 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eeb4715 - Browse repository at this point
Copy the full SHA eeb4715View commit details -
build: remove sudo:false from .travis.yml
sudo:false is being removed by Travis CI. Travis CI recommends removing the configuration. Fixes: #24510 PR-URL: #24511 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b61a51c - Browse repository at this point
Copy the full SHA b61a51cView commit details -
console: improve code readability
use object spread to make console code more readable PR-URL: #24412 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4f13ac7 - Browse repository at this point
Copy the full SHA 4f13ac7View commit details -
doc: add Beth Griggs to release team
PR-URL: #24532 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c16b932 - Browse repository at this point
Copy the full SHA c16b932View commit details -
doc: minor cleanup of tls.getProtocol()
Improve markup and return value description. PR-URL: #24533 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 40c9ee0 - Browse repository at this point
Copy the full SHA 40c9ee0View commit details -
http2: order declarations in http2.js
PR-URL: #24411 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 5516fbf - Browse repository at this point
Copy the full SHA 5516fbfView commit details -
test: modify order of parameters for assertion
PR-URL: #24430 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e7d41c0 - Browse repository at this point
Copy the full SHA e7d41c0View commit details -
src: elevate namespaces of repeated artifacts
PR-URL: #24429 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4b82aa8 - Browse repository at this point
Copy the full SHA 4b82aa8View commit details -
http2: replace unreachable error with assertion
"That particular `emit('error', ...)` is largely defensively coded and should not ever actually happen." Sounds like an assertion rather than an error event. The code in question has no test coverage because it is believed to be unreachable. Fixes: #20673 PR-URL: #24407 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8df4a16 - Browse repository at this point
Copy the full SHA 8df4a16View commit details -
cli: add missing env vars to --help
This adds NODE_TLS_REJECT_UNAUTHORIZED, SSL_CERT_DIR, SSL_CERT_FILE, and UV_THREADPOOL_SIZE to the --help menu. PR-URL: #24383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3ef68d8 - Browse repository at this point
Copy the full SHA 3ef68d8View commit details -
doc: add missing env variables to man page
This commit adds the missing environment variables NODE_DEBUG_NATIVE, NODE_PRESERVE_SYMLINKS, NODE_TLS_REJECT_UNAUTHORIZED, NODE_V8_COVERAGE, and UV_THREADPOOL_SIZE to the man page. PR-URL: #24383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for ef1056f - Browse repository at this point
Copy the full SHA ef1056fView commit details -
doc: add NODE_DEBUG_NATIVE to API docs
This commit adds the missing environment variable NODE_DEBUG_NATIVE to the CLI API docs. PR-URL: #24383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 6bb860c - Browse repository at this point
Copy the full SHA 6bb860cView commit details -
doc: move Timothy to TSC emeritus
PR-URL: #24535 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 08284dc - Browse repository at this point
Copy the full SHA 08284dcView commit details -
lib: move encodeStr function to internal for reusable
PR-URL: #24242 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4246a40 - Browse repository at this point
Copy the full SHA 4246a40View commit details -
test: replace anonymous closure with arrow funct
PR-URL: #24439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 66c3dca - Browse repository at this point
Copy the full SHA 66c3dcaView commit details -
test: replace anonymous closure functions with arrow function
PR-URL: #24420 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 283a6b8 - Browse repository at this point
Copy the full SHA 283a6b8View commit details -
test: replace anonymous closure functions with arrow functions
In `test/parallel/test-fs-truncate-fd.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't alter their context (`this`). This results in shorter functions. PR-URL: #24478 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7920e7b - Browse repository at this point
Copy the full SHA 7920e7bView commit details -
test: add whatwg-encoding TextDecoder custom inspection with showHidden
These tests ensure hidden fields are shown when inspecting with `showHidden` and that passing negative `depth` prints simplified value. Co-authored-by: Robin Drexler <drexler.robin@gmail.com> PR-URL: #24166 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8734c67 - Browse repository at this point
Copy the full SHA 8734c67View commit details -
src: elevate namespaces for repeated entities
PR-URL: #24475 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b7876ba - Browse repository at this point
Copy the full SHA b7876baView commit details -
doc: edit COLLABORATOR_GUIDE.md on closing issues
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it clear that all the text refers to issues *and* pull requests, etc.) PR-URL: #24477 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b1bbedd - Browse repository at this point
Copy the full SHA b1bbeddView commit details -
test: replace anonymous closure with arrow functions
PR-URL: #24481 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d245f53 - Browse repository at this point
Copy the full SHA d245f53View commit details -
doc: add Ruben Bridgewater to release team
PR-URL: #23432 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for f0602f8 - Browse repository at this point
Copy the full SHA f0602f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa60eb8 - Browse repository at this point
Copy the full SHA fa60eb8View commit details -
doc: move trott to tsc emeritus
(Effective after the next TSC meeting, November 21 2018.) I'm going to step away from TSC stuff for about 6 weeks. No exciting back-story here other than that I have a lot going on and I need a break. And I've also said that people should do exactly this more often. Maybe I'll make this an annual thing for me or something. While the decision of if and when to restore my TSC status is entirely up to the active members of the TSC, I intend to request to re-join in January. PR-URL: #24492 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for d288a39 - Browse repository at this point
Copy the full SHA d288a39View commit details -
test: refactor test-http-write-empty-string to use arrow functions
In `test/parallel/test-http-write-empty-string.js`, callbacks use anonymous closure functions. Replace them with arrow functions. PR-URL: #24483 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 351e69d - Browse repository at this point
Copy the full SHA 351e69dView commit details -
doc: add readable and writable property to Readable and Writable
PR-URL: #23933 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ba6ce6 - Browse repository at this point
Copy the full SHA 6ba6ce6View commit details -
doc: revise
author ready
explanationImprove the `author ready` text in the COLLABORATOR_GUIDE for scannability, readability, etc. PR-URL: #24558 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 98ef097 - Browse repository at this point
Copy the full SHA 98ef097View commit details -
build: fix Python detection when depot_tools are in PATH in Windows
PR-URL: #22539 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fa91037 - Browse repository at this point
Copy the full SHA fa91037View commit details -
Configuration menu - View commit details
-
Copy full SHA for b827db0 - Browse repository at this point
Copy the full SHA b827db0View commit details -
test: replcae anonymous closure with arrow function
PR-URL: #24476 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 44d9084 - Browse repository at this point
Copy the full SHA 44d9084View commit details -
doc: clarify who may land on an LTS staging branch
Current language is a bit confusing PR-URL: #24465 Refs: #24344 (comment) Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7e96c7f - Browse repository at this point
Copy the full SHA 7e96c7fView commit details -
test: replace callback with arrow functions
PR-URL: #24490 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 636de36 - Browse repository at this point
Copy the full SHA 636de36View commit details -
test: replace anonymous closure with arrow func
PR-URL: #24480 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fe96ecd - Browse repository at this point
Copy the full SHA fe96ecdView commit details -
- Using arrow functions in test-tls-client-resume.js - Fixed error, Expected parentheses around arrow function argument arrow-parens PR-URL: #24436 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8bd2399 - Browse repository at this point
Copy the full SHA 8bd2399View commit details -
test: replace closure with arrow function
PR-URL: #24489 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 31511c5 - Browse repository at this point
Copy the full SHA 31511c5View commit details -
test: refactor test to use arrow functions
In `test/parallel/test-cluster-send-deadlock.js`, callbacks use anonymous closure functions. It is safe to replace them with arrow functions since these callbacks don't contain references to `this`, `super` or `arguments`. This results in shorter functions. PR-URL: #24479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 952842b - Browse repository at this point
Copy the full SHA 952842bView commit details -
test: remove unused reject handlers
PR-URL: #24540 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Configuration menu - View commit details
-
Copy full SHA for b332a78 - Browse repository at this point
Copy the full SHA b332a78View commit details -
test: favor arrow function in callback
PR-URL: #24542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d41c988 - Browse repository at this point
Copy the full SHA d41c988View commit details -
test: replace anonymous function with arrow function
PR-URL: #24529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 9c29288 - Browse repository at this point
Copy the full SHA 9c29288View commit details -
test: replace closure functions with arrow functions
PR-URL: #24522 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 6ef3ec0 - Browse repository at this point
Copy the full SHA 6ef3ec0View commit details -
test: change anonymous closure function to arrow function
PR-URL: #24433 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 6b3b769 - Browse repository at this point
Copy the full SHA 6b3b769View commit details -
test: replace anonymous function with arrow func
PR-URL: #24525 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a7ab8f8 - Browse repository at this point
Copy the full SHA a7ab8f8View commit details -
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough information to know what was giong on. Adding a bit of information to the assertion that failed in case it fails again. PR-URL: #24566 Refs: #24565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 546af69 - Browse repository at this point
Copy the full SHA 546af69View commit details -
test: replace anonymous function with arrow
PR-URL: #24526 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 4ffc1e6 - Browse repository at this point
Copy the full SHA 4ffc1e6View commit details -
test: replace anonymous function with arrow
PR-URL: #24527 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af6de29 - Browse repository at this point
Copy the full SHA af6de29View commit details -
test: replace callback with arrow function
PR-URL: #24531 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c65063d - Browse repository at this point
Copy the full SHA c65063dView commit details -
test: replace callback with arrow functions
PR-URL: #24541 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8efb16a - Browse repository at this point
Copy the full SHA 8efb16aView commit details -
test: fix test case in test-child-process-fork-dgram.js
PR-URL: #24459 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 559ca1c - Browse repository at this point
Copy the full SHA 559ca1cView commit details -
test: use destructuring on require
PR-URL: #24455 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 106a1a1 - Browse repository at this point
Copy the full SHA 106a1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for adb5d4f - Browse repository at this point
Copy the full SHA adb5d4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 297c9d1 - Browse repository at this point
Copy the full SHA 297c9d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7840f71 - Browse repository at this point
Copy the full SHA 7840f71View commit details