Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document NODE_TLS_REJECT_UNAUTHORIZED #24289

Closed
wants to merge 1 commit into from
Closed

doc: document NODE_TLS_REJECT_UNAUTHORIZED #24289

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 10, 2018

This commit documents the NODE_TLS_REJECT_UNAUTHORIZED environment variable so that the world can know how potentially dangerous it is.

Fixes: #24284

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@cjihrig
doc: document NODE_TLS_REJECT_UNAUTHORIZED
bf6944b 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.
@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1569/pipeline

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Nov 10, 2018
@vsemozhetbyt
Copy link
Contributor

Maybe doc/node.1 and lib/internal/print_help.js should also be updated.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2018
@sam-github
Copy link
Contributor

I don't know how detailed you want to get here, but maybe worth documenting this as only applying to tls.connect() (client side validation of server certs). Perhaps describe it as the default value of rejectUnauthorized for tls.connect().

@Trott
Copy link
Member

Trott commented Nov 14, 2018

Lite CI again: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1598/pipeline

@Trott
Copy link
Member

Trott commented Nov 14, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1607/

@Trott
Copy link
Member

Trott commented Nov 14, 2018

The continued lite CI failure is baffling. It seems impossible that this doc change could be causing a test failure...

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1608/

@Trott
Copy link
Member

Trott commented Nov 14, 2018

Giving up and going with a full CI: https://ci.nodejs.org/job/node-test-pull-request/18606/

@Trott
Copy link
Member

Trott commented Nov 14, 2018

That time linuxone passed! Landing.

@Trott
Copy link
Member

Trott commented Nov 14, 2018

Landed in 9409883

@Trott Trott closed this Nov 14, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 14, 2018
@cjihrig @Trott
doc: document NODE_TLS_REJECT_UNAUTHORIZED
9409883 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: nodejs#24289
Fixes: nodejs#24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@cjihrig @BridgeAR
doc: document NODE_TLS_REJECT_UNAUTHORIZED
25065ca 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: #24289
Fixes: #24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@cjihrig @kiyomizumia
doc: document NODE_TLS_REJECT_UNAUTHORIZED
ced4cf7 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: nodejs#24289
Fixes: nodejs#24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@oyyd oyyd mentioned this pull request Nov 15, 2018
Closed
4 tasks
BridgeAR pushed a commit that referenced this pull request Nov 15, 2018
@cjihrig @BridgeAR
doc: document NODE_TLS_REJECT_UNAUTHORIZED
36e4d0c 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: #24289
Fixes: #24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 15, 2018
Merged
@cjihrig cjihrig deleted the doc branch November 15, 2018 20:18
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
This was referenced Nov 16, 2018
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@cjihrig @codebytere
doc: document NODE_TLS_REJECT_UNAUTHORIZED
1ca3c9d 
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED
environment variable so that the world can know how
potentially dangerous it is.

PR-URL: #24289
Fixes: #24284
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @nodejs-github-bot @vsemozhetbyt @sam-github @Trott @jasnell @lpinca @BridgeAR @trivikr