Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Using arrow functions #24436

Closed
wants to merge 1 commit into from
Closed

test: Using arrow functions #24436

wants to merge 1 commit into from

Conversation

NoSkillGirl
Copy link
Contributor

Using arrow functions in test-tls-client-resume.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos reviewed Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should look like test: use arrow functions

test/parallel/test-tls-client-resume.js Outdated
const server = tls.Server(options, common.mustCall(function(socket) {
socket.end('Goodbye');
}, 2));
const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const server = tls.Server(options, common.mustCall( socket => socket.end('Goodbye'), 2));
const server = tls.Server(options, common.mustCall(socket => socket.end('Goodbye'), 2));

@NoSkillGirl NoSkillGirl force-pushed the testcase-arrowfunctions branch from 0ee9e42 to 75cf1d4 Compare November 20, 2018 23:55
@NoSkillGirl NoSkillGirl force-pushed the testcase-arrowfunctions branch from 75cf1d4 to 362b69d Compare November 21, 2018 00:02
@NoSkillGirl NoSkillGirl force-pushed the testcase-arrowfunctions branch from 0d6b3c8 to 272d172 Compare November 21, 2018 02:15
@NoSkillGirl NoSkillGirl force-pushed the testcase-arrowfunctions branch from 272d172 to e12f560 Compare November 21, 2018 06:48
@gireeshpunathil
Copy link
Member

ping @NoSkillGirl

@NoSkillGirl NoSkillGirl force-pushed the testcase-arrowfunctions branch from e12f560 to 0dbe2f8 Compare November 21, 2018 15:28
@NoSkillGirl
Copy link
Contributor Author

Pong @gireeshpunathil

@NoSkillGirl
test: using arrow functions
d91a981 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

    PR-URL: nodejs#24436
@NoSkillGirl NoSkillGirl force-pushed the testcase-arrowfunctions branch from 0dbe2f8 to d91a981 Compare November 21, 2018 16:22
@danbev
Copy link
Contributor

danbev commented Nov 22, 2018 •
edited
Loading

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/18866/ ✔️

@danbev
Copy link
Contributor

danbev commented Nov 22, 2018

Landed in 282e533. 🎉

@danbev danbev closed this Nov 22, 2018
danbev pushed a commit that referenced this pull request Nov 22, 2018
@NoSkillGirl @danbev
test: using arrow functions
282e533 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@NoSkillGirl
Copy link
Contributor Author

Thank You @danbev

targos pushed a commit that referenced this pull request Nov 24, 2018
@NoSkillGirl @targos
test: using arrow functions
82ed615 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@NoSkillGirl @rvagg
test: using arrow functions
1cd73a8 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
This was referenced Dec 8, 2018
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@NoSkillGirl @codebytere
test: using arrow functions
6e7d867 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@NoSkillGirl @refack
test: using arrow functions
f4319d7 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: nodejs#24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@NoSkillGirl @codebytere
test: using arrow functions
0a2cd50 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@NoSkillGirl @codebytere
test: using arrow functions
8bd2399 
    - Using arrow functions in test-tls-client-resume.js
    - Fixed error, Expected parentheses around arrow function
      argument arrow-parens

PR-URL: #24436
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NoSkillGirl @gireeshpunathil @danbev @jasnell @targos @nodejs-github-bot