-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: sort bottom-of-file markdown links #24679
Conversation
@sam-github sadly an error occured when I tried to trigger a build :( |
This won't land on 11, 10, 8, so I prepared backports immediately, see: |
We still have one inconsistency. In ASCII the order is: [`DeflateRaw`]: #zlib_class_zlib_deflateraw
[`Deflate`]: #zlib_class_zlib_deflate However, as for the first symbol, some documents have upper case letters before backticks (i.e. [Using `options.selectPadding()`]: #http2_using_options_selectpadding
[`'checkContinue'`]: #http2_event_checkcontinue some documents have upper case letters after backtick (i.e. not consistently): [`strict mode`]: #assert_strict_mode
[Abstract Equality Comparison]: https://tc39.github.io/ecma262/#sec-abstract-equality-comparison |
@vsemozhetbyt I didn't try to fix all inconsistencies, my goal was to make it locally consistent. There was a fair number of unsorted-by-any-algorithm positions. Maybe that's a mistake. I would personally prefer to have strict ordering according to the default "C"/Posix locale -- which is ASCII ordering. Entirely ASCII makes it much faster to pass the entire block through programmer's editor's sort command, but IIRC from my first crack at this, existing usage had the backtick docs before all others, so I kept that in order to minimize churn. |
Btw, I'm willing to go through and resort all the open sorting PRs, time consuming though it is, but only if I know they will be rubber stamped. |
If you mean the backport PRs, they still have no reviews, but I plan to review them. And I usually compare automatically-sorted-in-editor lists with your variants when the diff is big) |
Should I wait for resorting in the backporting PRs? |
Should you wait? I don't know. If you are OK with this one landing, then yes, go ahead and review the others so they can all land at about the same time. None of them are backports in the sense that I didn't use git to make them, there are too many differences between branches. I went through and sorted I think the current set of PRs makes all the files locally consistent, which isn't just cosmetic. Its sort of a flag day... any commits landing on master after this that touch the markdown refs will have trouble cherry-picking back to the branches, unless those branches are already sorted. It would be really nice to have a markdown test tool that enforced ordering. |
I am OK with this one landing as is. I will try to review the others tomorrow. |
It seems this need rebasing to run CI. |
cfab420
to
e208a16
Compare
PTAL |
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
I'd like to fast-track to avoid conflicts. |
Reapply nodejs#12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that.
e208a16
to
f34fede
Compare
Backport-PR-URL: nodejs#24680 PR-URL: nodejs#24679 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reapply nodejs#12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that. PR-URL: nodejs#24679 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reapply #12726
It would be nice to have the sort check applied as part of doc testing,
but this change doesn't implement that.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes