Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: correctly pause and resume after once('readable') #24366

Closed
wants to merge 1 commit into from
Closed

stream: correctly pause and resume after once('readable') #24366

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Fixes: #24281

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1611/pipeline

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Nov 14, 2018
@mcollina mcollina mentioned this pull request Nov 14, 2018
Closed
addaleax
addaleax approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like there might be some simplification possible here, but I’m not seeing it right away :)

@tvald tvald mentioned this pull request Nov 19, 2018
Closed
@mcollina
Copy link
Member Author

Ci: https://ci.nodejs.org/job/node-test-pull-request/18811/

@mcollina
Copy link
Member Author

Landed in 69cc58d

@mcollina mcollina closed this Nov 21, 2018
@mcollina mcollina deleted the resume-after-readable branch November 21, 2018 11:17
mcollina added a commit that referenced this pull request Nov 21, 2018
@mcollina
stream: correctly pause and resume after once('readable')
69cc58d 
Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 21, 2018
@mcollina @targos
stream: correctly pause and resume after once('readable')
aa4d662 
Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@mcollina @rvagg
stream: correctly pause and resume after once('readable')
ba1ebb4 
Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
@mcollina
Copy link
Member Author

@nodejs/lts @nodejs/backporters @nodejs/releasers can you please include this in the next 10.x patch release?

codebytere pushed a commit that referenced this pull request Jan 13, 2019
@mcollina @codebytere
stream: correctly pause and resume after once('readable')
30455be 
Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@mcollina @refack
stream: correctly pause and resume after once('readable')
96c5c7e 
Fixes: nodejs#24281

PR-URL: nodejs#24366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@mcollina @codebytere
stream: correctly pause and resume after once('readable')
fa60eb8 
Fixes: #24281

PR-URL: #24366
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@mcollina mcollina mentioned this pull request Feb 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@fhinkel fhinkel fhinkel approved these changes

@mafintosh mafintosh Awaiting requested review from mafintosh

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream.resume() doesn't make the stream flowing after removing readable listener
5 participants
@mcollina @nodejs-github-bot @fhinkel @addaleax @BethGriggs