-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test adoption of Python API with the New and Old Kernel Picker #11963
Comments
@weinand there's a lot here, but what ever you can do to help would be great. |
@DonJayamanne I had a notebook setup from some previous experiments and I tried to understand the differences between the "traditional" and the "experimental" picker. From my very limited experience and understanding of notebooks kernels I prefer the "traditional" over the "experimental" picker: The "traditional" picker is a real picker because it shows what is available and I can actually "pick" something. The new selection is more like a "Get Info" window that shows the currently selected values. |
My impression of the slowness that @DonJayamanne mentioned In stable and insiders, I think the run button shows up at about the same time. Around 7-9s from "reload window" to the run button appearing, hard to tell whether stable is slightly faster. But after it appears, and the preferred kernel has been discovered, I see "Discovering Kernels" for another 5s or more, which could lead to an impression of slowness if the user doesn't realize they can go ahead and run a cell at this point. |
Is this just running |
@roblourens - jupyter has a clear cache command as well if you add the setting |
I did the best I could testing on WSL, but it's hard just due to everything in the windows VM being really slow. On the latest attempt, "Detecting Kernels" has been running for half an hour. So I did a lot of testing on mac and with SSH as well I saw this once or twice, but I can't really repro it. Let me know if you want an issue:
|
Testing adoption of the new Python Extension API for discovering Python Enviornmnents
Refs: #11904
Complexity: 5
Authors: @DonJayamanne , @rebornix
Create Issue
Notes
Use the setting
Kernel Picker Type
to toggle between regular kernel picker (all
) and the new one (mru
)Pre-Test
Requirements
Scenarios/items to test (Note: test with old and new kernel pickers)
Verify you can use a Julia or .Net kernel with an ipynb notebook
Verify discovery status is displayed in the kernel status (where you see selected kernel)
Verify the same kernels (kernel specs and Python environments) are still displayed in the kernel picker
New Virtual environments are detected and displayed in the Kernel picker
Note: You need to have already executed a cell in some notebook
Then create a virtual environment within VS Code
I.e. the goal is to test detection of new virtual envs after the extension has been used for a while
To test this, create a few variables, at least one with a list e.g.
a = [1,2,3]
and use the variable viewer to open the variablea
New Conda environments are detected and displayed in the Kernle picker
Note: You need to have already executed a cell in some notebook
Then create a conda environment within VS Code
I.e. the goal is to test detection of new virtual envs after the extension has been used for a while
To test this, create a few variables, at least one with a list e.g.
a = [1,2,3]
and use the variable viewer to open the variablea
Re-load VS Code and verify you can pick a Kernel Spec before Python environments
I'm hoping some machines are slow enough and we can see Kernel Specifications before Python environments in the kernel picker.
In the past we regressed in this space and Jupyter extension waited for ALL python environnents to be loaded before displaying Kernel Specs on disc.
We're verifyhing the fact that some kernels will appear before others
Verify local kernel specs appera before Remote Kernel specs
Connect to a local Jupyter server after having started a jupyter server using
jupyter notebook --no-browser --NotebookApp.allow_origin=*
In the past we regressed in this space and Jupyter extension waited for ALL python environnents to be loaded before displaying Kernel Specs on disc.
We're verifyhing the fact that some kernels will appear before others
Run a cell against a virtual env/or conda env and then delete that virtual/conda env and verify the selected kernel no longer points to that deleted environment.
Delete a virtual python environment and veriy the kernel is no longer listed in your kernel picker
Delete a conda python environment and veriy the kernel is no longer listed in your kernel picker
Connect to multiple remote jupyter servers
Test the new Kernel Picker (go into settings and toggle kernel picker to
all -> mru
ormru -> all
)"jupyter.development": true,
to your user settings and then use the commandClear Cache (dev)
Python: Clear Cache and Reload Window
The text was updated successfully, but these errors were encountered: