Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much text in kernel source picker #12213

Closed
roblourens opened this issue Nov 29, 2022 · 5 comments
Closed

Too much text in kernel source picker #12213

roblourens opened this issue Nov 29, 2022 · 5 comments
Assignees
Labels
notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker polish Cleanup and polish issue
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Nov 29, 2022

Testing #11963

image

We shouldn't have descriptions on items that just restate the titles. It's a lot of text and makes this picker a little overwhelming. Also the "kernel spec" item shouldn't be listed first when it's less likely than "python environments". And the items that lead to another selection screen should end in ...

@DonJayamanne
Copy link
Contributor

Also the "kernel spec" item shouldn't be listed first when it's less likely than "python environments".

kai suggested the other way, that's why we changed it.
his argument was doing the lines this is extension is supposed to work well for all jupyter kernels, not have too much special casing for python

@rebornix
Copy link
Member

We shouldn't have descriptions on items that just restate the titles

I like the richer quick pick a bit more. With that said, we don't have detail in a few other places, like the remote picker, so I'm fine with removing the detail and use title only.

@DonJayamanne
Copy link
Contributor

@rebornix as this is a change in vscode, i'll leave this for you. I don't want to remove the items from Jupyter extension. i think its simpler to remove from vscode and have a consistent UX (for all controllers and sources from all extensions)

@DonJayamanne
Copy link
Contributor

And the items that lead to another selection screen should end in ...

I can add this

@DonJayamanne DonJayamanne added polish Cleanup and polish issue kernel-picker labels Nov 30, 2022
@DonJayamanne DonJayamanne added this to the December 2022 milestone Nov 30, 2022
@rebornix rebornix added notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker mru and removed kernel-picker labels Dec 9, 2022
@DonJayamanne
Copy link
Contributor

This should now be fixed in the latest vscode and jupyter extension.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants