Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel creation feels slower #167683

Closed
rebornix opened this issue Nov 30, 2022 · 1 comment
Closed

Kernel creation feels slower #167683

rebornix opened this issue Nov 30, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker verified Verification succeeded
Milestone

Comments

@rebornix
Copy link
Member

    My impression of the slowness that @DonJayamanne mentioned

In stable and insiders, I think the run button shows up at about the same time. Around 7-9s from "reload window" to the run button appearing, hard to tell whether stable is slightly faster.

But after it appears, and the preferred kernel has been discovered, I see "Discovering Kernels" for another 5s or more, which could lead to an impression of slowness if the user doesn't realize they can go ahead and run a cell at this point.

Originally posted by @roblourens in microsoft/vscode-jupyter#11963 (comment)

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker labels Nov 30, 2022
@rebornix rebornix added this to the November 2022 milestone Nov 30, 2022
@rebornix
Copy link
Member Author

image

When there is already a selected kernel, we should show the kernel name and a spinner if there are pending detection tasks.

@rebornix rebornix self-assigned this Nov 30, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 30, 2022
@connor4312 connor4312 added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants