Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Detecting kernels" spinner icon spins the whole button when in the editor toolbar #167769

Closed
roblourens opened this issue Nov 30, 2022 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons

Comments

@roblourens
Copy link
Member

Testing microsoft/vscode-jupyter#11963
Recording 2022-11-30 at 12 44 05

@DonJayamanne DonJayamanne removed their assignment Nov 30, 2022
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Nov 30, 2022
@rebornix
Copy link
Member

rebornix commented Dec 1, 2022

Thanks, it's an issue with the spinner background. It should only spin the icon but not the bg.

@rebornix rebornix assigned daviddossett and unassigned rebornix Dec 1, 2022
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Dec 1, 2022
@daviddossett
Copy link
Contributor

I recall @jrieken having to do some slick element selection in the language status item to make sure only the icon animated, not icon + it's container. Does this look at all similar?

@jrieken
Copy link
Member

jrieken commented Dec 2, 2022

For the wiggle I make sure this only targets the codicon, not the entire button via: SPAN.codicon.wiggle

@roblourens @rebornix Are you just using a codicon with the spin modifier or is this something custom?

@daviddossett daviddossett added the icons-product Issues for in-product icons label Dec 6, 2022
@roblourens
Copy link
Member Author

This seems to not repro anymore

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons
Projects
None yet
Development

No branches or pull requests

5 participants