Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRU quick pick doesn't close when clicking away #12219

Closed
amunger opened this issue Nov 29, 2022 · 3 comments · Fixed by #12220
Closed

MRU quick pick doesn't close when clicking away #12219

amunger opened this issue Nov 29, 2022 · 3 comments · Fixed by #12220
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker verified Verification succeeded
Milestone
November 2022

Comments

@amunger
Copy link
Contributor

amunger commented Nov 29, 2022

Testing #11963

open the MRU quick pick
click "select another kernel" and pick one of the next options
click elsewhere in the editor to close the quick pick

quick pick does not close (it does close for the earlier stages of the quick pick)
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Nov 29, 2022 •
edited
Loading

hmm, this is a deliberate decision (deliberately configured as such in code), no idea why though.

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker labels Nov 30, 2022
@rebornix
Copy link
Member

We should at least be consistent.

@rebornix rebornix transferred this issue from microsoft/vscode-jupyter Nov 30, 2022
@DonJayamanne
Copy link
Contributor

I will make the change so that it goes away when you focus out, as that how most quickpicks work today.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode Nov 30, 2022
@DonJayamanne DonJayamanne mentioned this issue Nov 30, 2022
Merged
@DonJayamanne DonJayamanne added this to the November 2022 milestone Nov 30, 2022
@amunger amunger added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Hide kernel quick pick on focus out microsoft/vscode-jupyter
3 participants
@rebornix @DonJayamanne @amunger