Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MSI installer should warn user about unsupported OS #980

Closed
DaveTryon opened this issue Nov 15, 2023 · 2 comments
Closed

[BUG] MSI installer should warn user about unsupported OS #980

DaveTryon opened this issue Nov 15, 2023 · 2 comments

Comments

@DaveTryon
Copy link
Contributor

Describe the bug

In #833, we changed the CLI from .NET Core 3.1 to .NET 6.0. As a result of this change, the CLI no longer supports Windows 7. The installer should check for an OS version earlier than Windows 10, then display an error message that explains that the CLI is only supported on Windows 10 or newer.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/microsoft/axe-windows/releases/tag/v2.3.0
  2. Download the MSI installer
  3. Install it on Windows 7 (you'll need to install .NET 6.0 before running the installer)
  4. Installation will succeed
  5. Launch AxeWindowsCLI.exe

Expected behavior

The app should display the supported help screen

Actual behavior

The app displays a message that the app isn't compatible with the OS

Screenshots or .GIF

Desktop (please complete the following information):

  • OS: Windows 7
  • Axe Windows Version: 2.3.0

Additional context

Priority requested -
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Nov 15, 2023
@DaveTryon DaveTryon mentioned this issue Nov 15, 2023
Merged
DaveTryon added a commit that referenced this issue Nov 16, 2023
@DaveTryon
chore: Update installer message for .NET version (#981)
87c3796 
#### Details

#833 updated the CLI from .NET Core 3.1 to .NET 6.0 because .NET Core
3.1 had reached its end of life. Unfortunately, the error message that
tells the user the minimum version was not updated. This PR simply
corrects that omission and tells the user to install .NET 6.0 or newer.

##### Motivation

Usability

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->
The CLI no longer supports Windows 7. This is tracked at #980 and not
addressed here.

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue
@DaveTryon DaveTryon moved this from Needs triage to Accepted - vendor in Accessibility Insights Nov 20, 2023
@v-singhanjal
Copy link
Contributor

We have done changes to get the message regarding the Windows Version on Windows7. The message looks like this:
Screenshot 2023-12-18 185645
Please review and let us know if any further changes needs to be done.

This was referenced Jan 3, 2024
Closed
Merged
@v-viyada v-viyada added active (Dev) The assigned dev is working to perform the work. status: active This issue is currently being worked on by someone. and removed status: new This issue is new and requires triage by DRI. active (Dev) The assigned dev is working to perform the work. labels Jan 5, 2024
DaveTryon pushed a commit that referenced this issue Jan 10, 2024
@v-singhanjal
fix: MSI installer should warn user about unsupported OS. (#986)
eff1ffe 
#### Details

<!-- Usually a sentence or two describing what the PR changes -->
MSI installer should warn user about unsupported Operating System.
Associated Issue: #980

##### Motivation

<!-- This can be as simple as "addresses issue #123" -->
Fix implemented for:

- To warn user about unsupported Operating System by displaying a
message as: Axe.Windows Command Line Interface (CLI)

  requires .NET 6, which is supported on Windows 10 or newer.

- Screenshot of the implemented fix: 
  

![image](https://github.com/microsoft/axe-windows/assets/150343275/35a12a0f-0e47-44d4-9309-6916a193dcfa)

- Locally tested all the changes and they are working as expected.

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#980
- [x] Added screenshots/GIFs to description above
@DaveTryon DaveTryon moved this from Accepted - vendor to Needs release in Accessibility Insights Jan 22, 2024
@DaveTryon DaveTryon added status: resolved This issue has been merged into main. and removed status: active This issue is currently being worked on by someone. labels Jan 22, 2024
@DaveTryon
Copy link
Contributor Author

Released in https://github.com/microsoft/axe-windows/releases/tag/v2.3.1

@DaveTryon DaveTryon removed the status: resolved This issue has been merged into main. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DaveTryon @v-viyada @JeevaniChinthala @v-singhanjal