Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MSI installer should warn user about unsupported OS. #986

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

v-singhanjal
Copy link
Contributor

Details

MSI installer should warn user about unsupported Operating System.
Associated Issue: #980

Motivation

Fix implemented for:

  • To warn user about unsupported Operating System by displaying a message as: Axe.Windows Command Line Interface (CLI)

    requires .NET 6, which is supported on Windows 10 or newer.

  • Screenshot of the implemented fix:

image

  • Locally tested all the changes and they are working as expected.
Context

Pull request checklist

@v-singhanjal v-singhanjal requested a review from a team as a code owner January 4, 2024 11:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 426 lines in your changes are missing coverage. Please review.

Comparison is base (4fc19c3) 73.70% compared to head (37ac55b) 71.70%.
Report is 359 commits behind head on main.

❗ Current head 37ac55b differs from pull request most recent head 3f72731. Consider uploading reports for the commit 3f72731 to get more accurate results

Files Patch % Lines
src/Actions/Actions/SelectAction.cs 59.09% 29 Missing and 7 partials ⚠️
src/Actions/Trackers/FocusTracker.cs 15.00% 33 Missing and 1 partial ⚠️
src/Actions/Actions/GetDataAction.cs 15.15% 27 Missing and 1 partial ⚠️
src/CLI/Program.cs 0.00% 28 Missing ⚠️
src/Actions/Actions/ListenAction.cs 0.00% 23 Missing ⚠️
src/Actions/Actions/DataManager.cs 58.82% 20 Missing and 1 partial ⚠️
src/Actions/Trackers/BaseTracker.cs 36.00% 15 Missing and 1 partial ⚠️
src/Automation/Resources/ErrorMessages.Designer.cs 40.00% 15 Missing ⚠️
src/Core/Bases/A11yElement.cs 65.00% 3 Missing and 11 partials ⚠️
src/Actions/Trackers/MouseTracker.cs 50.00% 12 Missing ⚠️
... and 44 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   73.70%   71.70%   -2.00%     
==========================================
  Files         398      424      +26     
  Lines       12046    13117    +1071     
  Branches        0     1416    +1416     
==========================================
+ Hits         8878     9405     +527     
- Misses       3168     3297     +129     
- Partials        0      415     +415     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v-viyada v-viyada marked this pull request as draft January 4, 2024 15:27
@v-viyada v-viyada marked this pull request as ready for review January 5, 2024 16:34
@v-singhanjal v-singhanjal changed the title fix: MSI installer should warn user about unsupported OS. #980 fix: MSI installer should warn user about unsupported OS. Jan 8, 2024
@v-singhanjal v-singhanjal marked this pull request as draft January 8, 2024 15:03
@v-singhanjal v-singhanjal marked this pull request as ready for review January 8, 2024 15:08
Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @v-singhanjal! I verified that the error displays as expected on Win7 and that it does not display on either Win10 or Win11. LGTM!

@DaveTryon DaveTryon merged commit eff1ffe into microsoft:main Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants