Skip to content

Commit

Permalink
fix: MSI installer should warn user about unsupported OS. (#986)
Browse files Browse the repository at this point in the history
#### Details

<!-- Usually a sentence or two describing what the PR changes -->
MSI installer should warn user about unsupported Operating System.
Associated Issue: #980

##### Motivation

<!-- This can be as simple as "addresses issue #123" -->
Fix implemented for:

- To warn user about unsupported Operating System by displaying a
message as: Axe.Windows Command Line Interface (CLI)

  requires .NET 6, which is supported on Windows 10 or newer.

- Screenshot of the implemented fix: 
  

![image](https://github.com/microsoft/axe-windows/assets/150343275/35a12a0f-0e47-44d4-9309-6916a193dcfa)

- Locally tested all the changes and they are working as expected.

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue:
#980
- [x] Added screenshots/GIFs to description above
  • Loading branch information
v-singhanjal authored Jan 10, 2024
1 parent f589bc7 commit eff1ffe
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/CLI_Installer/Product.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ Licensed under the MIT license. See LICENSE file in the project root for full li
<ComponentGroupRef Id="ProductComponents" />
<ComponentGroupRef Id="Net60ComponentGroup" />
</Feature>

<Launch Message="[ProductName] requires .NET 6, which is supported on Windows 10 or newer."
Condition="VersionNT >= 603"/>

<Launch Message="[ProductName] requires .NET Core Runtime 6.0 or newer. Please visit https://dotnet.microsoft.com/download/dotnet-core"
Condition="Installed OR NETCORERUNTIMEFOUNDX64 OR NETCORERUNTIMEFOUNDX86" />
Expand Down

0 comments on commit eff1ffe

Please sign in to comment.