Force ProcessName to string.Empty for all elements read from disk #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobGallo
approved these changes
Aug 1, 2019
waabid
pushed a commit
to waabid/axe-windows
that referenced
this pull request
May 18, 2021
Updating the spelling of "setting" to "settings".
DaveTryon
added a commit
that referenced
this pull request
Oct 19, 2022
#### Details In #767, we agreed to revisit refactoring the `A11yAutomation` class to avoid the possibility of the `DesktopDataContext` referencing a different `A11yAutomation` object. This PR does the following: 1. Removes the unused `GetFocusedElement` method (I confirmed it's not used by AIWin) 2. Makes the `GetAppElement` and `NormalizedElementFromPoint` static to avoid the chance their `DesktopDataContext` parameters refer to a different `A11yAutomation` object 3. Adds necessary internal checks to guard against a null `DesktopDataContext` 4. Removes the now-superfluous `EnsureContextConsistency` method 5. Updates the calling code 6. Tightens function visibility on the `A11yAutomation` object. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> I realized that the `TargetElementLocator` in the Automation assembly has a direct dependency on `A11yAutomation.ElementsFromProcessId`. That sort of violates our intended encapsulation of Automation doing everything through Actions, but the fix there is to refactor the `TargetElementLocator` class, which feels like a separate PR <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000
DaveTryon
pushed a commit
that referenced
this pull request
Jan 10, 2024
#### Details <!-- Usually a sentence or two describing what the PR changes --> MSI installer should warn user about unsupported Operating System. Associated Issue: #980 ##### Motivation <!-- This can be as simple as "addresses issue #123" --> Fix implemented for: - To warn user about unsupported Operating System by displaying a message as: Axe.Windows Command Line Interface (CLI) requires .NET 6, which is supported on Windows 10 or newer. - Screenshot of the implemented fix:  - Locally tested all the changes and they are working as expected. ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #980 - [x] Added screenshots/GIFs to description above
DaveTryon
pushed a commit
that referenced
this pull request
Jan 30, 2024
#### Details 1ES PT adds tags to pipeline runs using the access token provided by ADO. In the case of pipeline runs against forked repos of a GitHub repo, the access token does not have Edit build quality permissions and hence cannot add tags. To unblock those pipelines, skipped tagging by using the option SkipBuildTagsForGitHubPullRequests. Verified that the only change in the pipeline run is that it do not add "1ES.PT.Unofficial" tag on the Run. In place of that it adds below warning message. ##[warning]1ES PT Warning: Skipping build tags as this build is a pull request form github which does not have permissions to add tags. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: #0000
v-viyada
pushed a commit
that referenced
this pull request
Oct 18, 2024
) #### Details <!-- Usually a sentence or two describing what the PR changes --> Bumps [System.IO.Packaging](https://github.com/dotnet/runtime) from 8.0.0 to 8.0.1. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> This will resolve CG issue https://dev.azure.com/mseng/1ES/_componentGovernance/320/alert/239153?typeId=268109 ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [na] Addresses an existing issue: #0000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Force ProcessName to string.Empty for all elements read from disk. The current behavior is leading to a flaky unit test, depending on the ID's of other processes running on the build agent.