chore: Migrate EXE's from .NET Core 3.1 to .NET 6.0 #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
changed the title
sfoslund
approved these changes
Nov 9, 2022
DaveTryon
added a commit
that referenced
this pull request
Nov 16, 2022
#### Details When #833 changed the CLI to target .NET 6.0, it changed the path of the locally-built CLI, which (in turn) broke the validation script. This just fixes the validation script and makes the displayed instructions a little bit clearer. ##### Motivation Validation scripts should work ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue:
This was referenced Nov 15, 2023
DaveTryon
added a commit
that referenced
this pull request
Nov 16, 2023
#### Details #833 updated the CLI from .NET Core 3.1 to .NET 6.0 because .NET Core 3.1 had reached its end of life. Unfortunately, the error message that tells the user the minimum version was not updated. This PR simply corrects that omission and tells the user to install .NET 6.0 or newer. ##### Motivation Usability ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> The CLI no longer supports Windows 7. This is tracked at #980 and not addressed here. <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As called out in this blog post, .NET Core 3.1 ends LTS on 13 December 2022, which is coming up quickly. Some of our .NET dependencies are dropping support for .NET Core 3.1, so in order to stay on current binaries, we are shifting our EXE's to .NET 6.0. This includes the CLI and all test projects. The libraries in the NuGet package will continue to build using .NET Standard 2.0, so they'll continue to work in either .NET or .NET Framework applications. They will also continue to be Windows-specific, which makes sense since UIA is a Windows-specific technology.
Validation included:
Motivation
Avoid the situation where we depend on libraries that are out of support or untested in our install environment.
Context
This and #834 both involve the WXS file. Some merge resolution will be needed, no matter what order we merge.
Pull request checklist